Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: false negative in id-match rule #15443

Closed
1 task done
snitin315 opened this issue Dec 22, 2021 · 1 comment · Fixed by #15474
Closed
1 task done

Bug: false negative in id-match rule #15443

snitin315 opened this issue Dec 22, 2021 · 1 comment · Fixed by #15474
Assignees
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly repro:yes rule Relates to ESLint's core rules
Projects

Comments

@snitin315
Copy link
Contributor

snitin315 commented Dec 22, 2021

Environment

Node version: v14.18.1
npm version: v8.1.4
Local ESLint version: v8.4.1 (Currently used)
Global ESLint version: v8.4.1
Operating System: darwin 20.6.0

What parser are you using?

Default (Espree)

What did you do?

Online Demo

Configuration
/* eslint id-match: ["error", "^[^a]"] */

/* eslint id-match: ["error", "^[^a]"] */

const foo = {
 [a]: 1 // should be reported
};

What did you expect to happen?

/* eslint id-match: ["error", "^[^a]"] */

const foo = {
 [a]: 1 // Error: Identifier 'a' does not match the pattern '^[^a]'
};

What actually happened?

/* eslint id-match: ["error", "^[^a]"] */

const foo = {
 [a]: 1 // Lint free

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

Refers #15431 (comment).

@snitin315 snitin315 added bug ESLint is working incorrectly repro:needed labels Dec 22, 2021
@eslint-github-bot eslint-github-bot bot added this to Needs Triage in Triage Dec 22, 2021
@snitin315 snitin315 added repro:yes rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion and removed repro:needed labels Dec 22, 2021
@snitin315 snitin315 self-assigned this Dec 24, 2021
@nzakas
Copy link
Member

nzakas commented Dec 28, 2021

@snitin315 please be sure to move issues like this into “Ready to Implement” if you’re not looking for feedback.

If you are looking for feedback, leave off the “accepted” label and place in the “Feedback Needed” column.

@snitin315 snitin315 moved this from Needs Triage to Ready to Implement in Triage Dec 28, 2021
Triage automation moved this from Ready to Implement to Complete Jan 6, 2022
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jul 6, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly repro:yes rule Relates to ESLint's core rules
Projects
Archived in project
Triage
Complete
Development

Successfully merging a pull request may close this issue.

2 participants