Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support arbitrary module namespace names in the quotes rule #15479

Merged
merged 1 commit into from Jan 5, 2022

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Refs #15465, fixes quotes.

What changes did you make? (Give an overview)

Fixed the quotes rule to not enforce backticks in a ModuleExportName position.

Before this change, quotes had false positives on "foo", "bar", "baz", and "qux" in the following example:

/* eslint quotes: ["error", "backtick"] */

import { "foo" as a } from "mod";

export { "bar" as "baz" } from "mod";

export * as "qux" from "mod";

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion feature This change adds a new feature to ESLint new syntax This issue is related to new syntax that has reached stage 4 labels Jan 3, 2022
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

just a reminder: the option backtick will be gone away in the new config. cc @snitin315

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snitin315
Copy link
Contributor

just a reminder: the option backtick will be gone away in the new config.

I believe backtick will be allowed as { precedence: ['backtick'] }, allowTemplateLiterals will be removed tough.

@mdjermanovic mdjermanovic merged commit 3549571 into main Jan 5, 2022
@mdjermanovic mdjermanovic deleted the issue15465-quotes branch January 5, 2022 10:11
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jul 5, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion feature This change adds a new feature to ESLint new syntax This issue is related to new syntax that has reached stage 4 rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants