Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add enforceInClassFields option to no-underscore-dangle #15818

Merged
merged 3 commits into from May 4, 2022
Merged

feat: add enforceInClassFields option to no-underscore-dangle #15818

merged 3 commits into from May 4, 2022

Conversation

robertotcestari
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

Discussion about this fix is on #15810

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Apr 28, 2022
@eslint-github-bot
Copy link

Hi @robertotcestari!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Apr 28, 2022
This was referenced Apr 28, 2022
Closed
Closed
@mdjermanovic mdjermanovic changed the title fix: no-underscore-dangle support for private and public class fields feat: add enforceInClassFields option to no-underscore-dangle Apr 28, 2022
@mdjermanovic mdjermanovic added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion feature This change adds a new feature to ESLint and removed triage An ESLint team member will look at this issue soon bug ESLint is working incorrectly labels Apr 28, 2022
@mdjermanovic mdjermanovic linked an issue Apr 28, 2022 that may be closed by this pull request
Bug: no-underscore-dangle not working as expected in ES2022 public/private class fields #15810
Closed
1 task
mdjermanovic
mdjermanovic reviewed Apr 28, 2022
View reviewed changes
lib/rules/no-underscore-dangle.js Outdated Show resolved Hide resolved
lib/rules/no-underscore-dangle.js Outdated Show resolved Hide resolved
mdjermanovic
mdjermanovic reviewed Apr 28, 2022
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small request, and then LGTM.

tests/lib/rules/no-underscore-dangle.js Outdated Show resolved Hide resolved
mdjermanovic
mdjermanovic approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I'll leave this open for a few days in case anyone else wants to review it before merging.

@mdjermanovic mdjermanovic merged commit ab37d3b into eslint:main May 4, 2022
@mdjermanovic
Copy link
Member

Thanks for contributing!

pedrobritobr
pedrobritobr reviewed May 11, 2022
View reviewed changes
Copy link

@pedrobritobr pedrobritobr left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Monstro, fera demais, está em outro nível
Beast! You're in other level!

crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request May 13, 2022
Update dependency eslint to v8.15.0 (#1343)
9b18fbf 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.14.0` -> `8.15.0`](https://renovatebot.com/diffs/npm/eslint/8.14.0/8.15.0) |

---

### Release Notes

<details>
<summary>eslint/eslint</summary>

### [`v8.15.0`](https://github.com/eslint/eslint/releases/v8.15.0)

[Compare Source](eslint/eslint@v8.14.0...v8.15.0)

#### Features

-   [`ab37d3b`](eslint/eslint@ab37d3b) feat: add `enforceInClassFields` option to no-underscore-dangle ([#&#8203;15818](eslint/eslint#15818)) (Roberto Cestari)

#### Bug Fixes

-   [`8bf9440`](eslint/eslint@8bf9440) fix: "use strict" should not trigger strict mode in ES3 ([#&#8203;15846](eslint/eslint#15846)) (Milos Djermanovic)

#### Documentation

-   [`28116cc`](eslint/eslint@28116cc) docs: update AST node names link in no-restricted-syntax ([#&#8203;15843](eslint/eslint#15843)) (Milos Djermanovic)
-   [`272965f`](eslint/eslint@272965f) docs: fix h1 heading on formatters page ([#&#8203;15834](eslint/eslint#15834)) (Milos Djermanovic)
-   [`a798166`](eslint/eslint@a798166) docs: update example for running individual rule tests ([#&#8203;15833](eslint/eslint#15833)) (Milos Djermanovic)
-   [`57e732b`](eslint/eslint@57e732b) docs: mark `SourceCode#getJSDocComment` deprecated in working-with-rules ([#&#8203;15829](eslint/eslint#15829)) (Milos Djermanovic)
-   [`9a90abf`](eslint/eslint@9a90abf) docs: update docs directory in working-with-rules ([#&#8203;15830](eslint/eslint#15830)) (Milos Djermanovic)
-   [`810adda`](eslint/eslint@810adda) docs: add more examples for prefer-object-spread ([#&#8203;15831](eslint/eslint#15831)) (coderaiser)
-   [`06b1edb`](eslint/eslint@06b1edb) docs: clarify no-control-regex rule ([#&#8203;15808](eslint/eslint#15808)) (Milos Djermanovic)
-   [`9ecd42f`](eslint/eslint@9ecd42f) docs: Fixed typo in code comment ([#&#8203;15812](eslint/eslint#15812)) (Addison G)
-   [`de992b7`](eslint/eslint@de992b7) docs: remove links to 2fa document ([#&#8203;15804](eslint/eslint#15804)) (Milos Djermanovic)
-   [`5222659`](eslint/eslint@5222659) docs: fix 'Related Rules' heading in no-constant-binary-expression ([#&#8203;15799](eslint/eslint#15799)) (Milos Djermanovic)
-   [`e70ae81`](eslint/eslint@e70ae81) docs: Update README team and sponsors (ESLint Jenkins)

#### Chores

-   [`1ba6a92`](eslint/eslint@1ba6a92) chore: upgrade [@&#8203;eslint/eslintrc](https://github.com/eslint/eslintrc)[@&#8203;1](https://github.com/1).2.3 ([#&#8203;15847](eslint/eslint#15847)) (Milos Djermanovic)
-   [`8167aa7`](eslint/eslint@8167aa7) chore: bump version of minimatch due to security issue PRISMA-2022-0039 ([#&#8203;15774](eslint/eslint#15774)) (Jan Opravil)
-   [`b8995a4`](eslint/eslint@b8995a4) chore: Implement docs site ([#&#8203;15815](eslint/eslint#15815)) (Nicholas C. Zakas)
-   [`6494e3e`](eslint/eslint@6494e3e) chore: update link in `codeql-analysis.yml` ([#&#8203;15817](eslint/eslint#15817)) (Milos Djermanovic)
-   [`36503ec`](eslint/eslint@36503ec) chore: enable no-constant-binary-expression in eslint-config-eslint ([#&#8203;15807](eslint/eslint#15807)) (唯然)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1343
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
srijan-deepsource pushed a commit to DeepSourceCorp/eslint that referenced this pull request May 30, 2022
@robertotcestari @srijan-deepsource
feat: add enforceInClassFields option to no-underscore-dangle (esli…
7d93735 
…nt#15818)

* fix: no-underscore-dangle support for class fields (es2022)

* resolving code review suggestions

* resolving code review suggestions
srijan-deepsource added a commit to DeepSourceCorp/eslint that referenced this pull request May 30, 2022
@srijan-deepsource
Revert "feat: add enforceInClassFields option to no-underscore-dang…
9df8671 
…le (eslint#15818)"

This reverts commit 7d93735.
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 1, 2022
Closed
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Nov 1, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pedrobritobr pedrobritobr pedrobritobr left review comments

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint feature This change adds a new feature to ESLint rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: no-underscore-dangle not working as expected in ES2022 public/private class fields
3 participants
@robertotcestari @mdjermanovic @pedrobritobr