Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Request: no-restricted-syntax documentation link to AST node names 404s #15842

Closed
1 task
NilsMoller opened this issue May 6, 2022 · 1 comment · Fixed by #15843
Closed
1 task

Change Request: no-restricted-syntax documentation link to AST node names 404s #15842

NilsMoller opened this issue May 6, 2022 · 1 comment · Fixed by #15843
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
Triage

Comments

@NilsMoller
Copy link

ESLint version

v8.14.0

What problem do you want to solve?

The docs page for no-restricted-syntax has a GitHub link to the AST node names, which leads to a 404.

What do you think is the correct solution?

Either remove the link, or have it point to the correct web page.

Participation

  • I am willing to submit a pull request for this change.

Additional comments

No response
@NilsMoller NilsMoller added core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint triage An ESLint team member will look at this issue soon labels May 6, 2022
@eslint-github-bot eslint-github-bot bot added this to Needs Triage in Triage May 6, 2022
@NilsMoller NilsMoller changed the title Change Request: no-restricted-syntax AST node names link 404s Change Request: no-restricted-syntax documentation link to AST node names 404s May 6, 2022
@mdjermanovic mdjermanovic moved this from Needs Triage to Triaging in Triage May 6, 2022
mdjermanovic added a commit that referenced this issue May 6, 2022
@mdjermanovic
docs: update AST node names link in no-restricted-syntax
5d7be28 
Fixes #15842
@mdjermanovic mdjermanovic mentioned this issue May 6, 2022
Merged
1 task
@mdjermanovic mdjermanovic moved this from Triaging to Pull Request Opened in Triage May 6, 2022
@mdjermanovic mdjermanovic added rule Relates to ESLint's core rules documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion and removed enhancement This change enhances an existing feature of ESLint triage An ESLint team member will look at this issue soon core Relates to ESLint's core APIs and features labels May 6, 2022
@mdjermanovic
Copy link
Member

Thanks for finding this! I prepared PR #15843 to update the link.

Triage automation moved this from Pull Request Opened to Complete May 6, 2022
mdjermanovic added a commit that referenced this issue May 6, 2022
@mdjermanovic
docs: update AST node names link in no-restricted-syntax (#15843)
28116cc 
Fixes #15842
srijan-deepsource pushed a commit to DeepSourceCorp/eslint that referenced this issue May 30, 2022
@mdjermanovic @srijan-deepsource
docs: update AST node names link in no-restricted-syntax (eslint#15843)
de0124a 
Fixes eslint#15842
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Nov 3, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
Triage
Archived in project
Triage
Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: update AST node names link in no-restricted-syntax eslint/eslint
2 participants
@NilsMoller @mdjermanovic