feat: add Unicode flag suggestion in no-misleading-character-class #15867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 36396ba.
Add tests
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
eslint-github-bot
bot
added
triage
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mdjermanovic
added
enhancement
1 task
nzakas
approved these changes
May 20, 2022
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
May 24, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.15.0` -> `8.16.0`](https://renovatebot.com/diffs/npm/eslint/8.15.0/8.16.0) | --- ### Release Notes <details> <summary>eslint/eslint</summary> ### [`v8.16.0`](https://github.com/eslint/eslint/releases/tag/v8.16.0) [Compare Source](eslint/eslint@v8.15.0...v8.16.0) #### Features - [`cab0c22`](eslint/eslint@cab0c22) feat: add Unicode flag suggestion in no-misleading-character-class ([#​15867](eslint/eslint#15867)) (Milos Djermanovic) - [`38ae956`](eslint/eslint@38ae956) feat: check Unicode code point escapes in no-control-regex ([#​15862](eslint/eslint#15862)) (Milos Djermanovic) - [`ee69cd3`](eslint/eslint@ee69cd3) feat: Update global variables ([#​15871](eslint/eslint#15871)) (Sébastien Règne) #### Bug Fixes - [`3f09aab`](eslint/eslint@3f09aab) fix: function-paren-newline crash on "new new Foo();" ([#​15850](eslint/eslint#15850)) (coderaiser) #### Documentation - [`050d5f4`](eslint/eslint@050d5f4) docs: Static further reading links ([#​15890](eslint/eslint#15890)) (Nicholas C. Zakas) - [`36287c0`](eslint/eslint@36287c0) docs: fix absolute paths in related rules shortcode to work from /docs ([#​15892](eslint/eslint#15892)) (Milos Djermanovic) - [`90b6990`](eslint/eslint@90b6990) docs: fix absolute links in rule macro to work from /docs ([#​15891](eslint/eslint#15891)) (Milos Djermanovic) - [`f437249`](eslint/eslint@f437249) docs: Adjust docs site path prefix ([#​15889](eslint/eslint#15889)) (Nicholas C. Zakas) - [`6e16025`](eslint/eslint@6e16025) docs: update 'Related Rules' and 'Further Reading' in remaining rules ([#​15884](eslint/eslint#15884)) (Milos Djermanovic) - [`1d39f69`](eslint/eslint@1d39f69) docs: remove confusing examples for no-mixed-operators ([#​15875](eslint/eslint#15875)) (Milos Djermanovic) - [`3071d76`](eslint/eslint@3071d76) docs: Fix some grammar issues ([#​15837](eslint/eslint#15837)) (byodian) #### Chores - [`1768d0d`](eslint/eslint@1768d0d) chore: upgrade [@​eslint/eslintrc](https://github.com/eslint/eslintrc)[@​1](https://github.com/1).3.0 ([#​15903](eslint/eslint#15903)) (Milos Djermanovic) - [`c686e4c`](eslint/eslint@c686e4c) chore: Add deploy workflow for docs site ([#​15894](eslint/eslint#15894)) (Nicholas C. Zakas) - [`c7894cd`](eslint/eslint@c7894cd) chore: enable some rules from eslint-plugin-unicorn internally ([#​15878](eslint/eslint#15878)) (Bryan Mishkin) - [`ea65cb5`](eslint/eslint@ea65cb5) chore: upgrade eslint-plugin-eslint-plugin@^4.2.0 ([#​15882](eslint/eslint#15882)) (唯然) - [`cc29c69`](eslint/eslint@cc29c69) chore: Upgrade official GitHub actions to latest versions ([#​15880](eslint/eslint#15880)) (Darius Dzien) - [`5891c75`](eslint/eslint@5891c75) chore: Refactor rule docs format ([#​15869](eslint/eslint#15869)) (Nicholas C. Zakas) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1366 Reviewed-by: 6543 <6543@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
srijan-deepsource
pushed a commit
to DeepSourceCorp/eslint
that referenced
this pull request
May 30, 2022
…slint#15867) * refactor: Simplify kinds tracking with a Set * feat: Add fixer for missing regex unicode flag * test: Update tests * refactor: Change fix to suggestion * Revert "test: Update tests" * Address review comments * Add tests * Update lib/rules/no-misleading-character-class.js Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> * add suggestions:null assertions * update docs * add more tests * fix edge cases when inserting flags argument * validate pattern for regex literals * validate pattern for regex constructor calls Co-authored-by: Mathias Rasmussen <mathiasvr@gmail.com>
srijan-deepsource
added a commit
to DeepSourceCorp/eslint
that referenced
this pull request
May 30, 2022
…class (eslint#15867)" This reverts commit 7783239.
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Continued from #15279.
Adds Unicode flag suggestion in the
no-misleading-character-classrule.What changes did you make? (Give an overview)
Addressed code reviews from #15279.
Is there anything you'd like reviewers to focus on?