docs: Update website UI to latest #15944

nzakas · 2022-05-30T18:43:04Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

This syncs the docs website UI with the latest from the prototype. I also double-checked that links are correctly using pathPrefix where appropriate and added the CSS file to .gitignore as we do for the main website.

Is there anything you'd like reviewers to focus on?

Does everything look okay?

netlify · 2022-05-30T18:43:09Z

✅ Deploy Preview for docs-eslint ready!

Name	Link
🔨 Latest commit	`ae3004a`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/6296b25f67a84100090933a4
😎 Deploy Preview	https://deploy-preview-15944--docs-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

docs/src/assets/scss/utilities.scss

docs/src/_includes/components/nav-version-switcher.html

mdjermanovic

This is a duplicate id (the same as in version-switcher.html).

docs/src/_includes/components/nav-version-switcher.html

mdjermanovic · 2022-05-31T00:12:52Z

Print style seems broken.

main branch

this branch

docs/src/_includes/components/docs-toc.html

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

docs/src/_includes/components/navigation.html

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

nzakas · 2022-05-31T00:50:48Z

Can you open a separate issue for the print style?

docs/src/_includes/components/theme-switcher.html

docs/src/assets/js/focus-visible.js

docs/src/assets/js/main.js

docs/src/assets/js/components-index.js

docs/src/assets/js/main.js

mdjermanovic · 2022-05-31T12:25:21Z

docs/src/_includes/layouts/doc.html

+                <aside class="docs-ad">
+                    {%- include 'partials/carbon-ad.html' -%}
+                </aside>
+                {% include 'components/docs-toc.html' %}


This will add duplicate ids js-toc-label and js-toc-panel, and we have a script that targets these ids, so it might be better to fix this to avoid unexpected behavior in different browsers.

I think we should hold off on dealing with this now. Let's just get the current prototype version deployed and then we can see if this is actually causing any problems and narrowly focus on solving it.

Agreed. Everything else LGTM, so I'll merge this now to be deployed.

mdjermanovic · 2022-05-31T13:14:39Z

Can you open a separate issue for the print style?

#15948

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.16.0` -> `8.17.0`](https://renovatebot.com/diffs/npm/eslint/8.16.0/8.17.0) | --- ### Release Notes <details> <summary>eslint/eslint</summary> ### [`v8.17.0`](https://github.com/eslint/eslint/releases/tag/v8.17.0) [Compare Source](eslint/eslint@v8.16.0...v8.17.0) #### Features - [`55319e1`](eslint/eslint@55319e1) feat: fix indent bug with semicolon-first style ([#15951](eslint/eslint#15951)) (Milos Djermanovic) - [`f6d7920`](eslint/eslint@f6d7920) feat: add `allowNamedExports` option to no-use-before-define ([#15953](eslint/eslint#15953)) (Milos Djermanovic) #### Bug Fixes - [`54c0953`](eslint/eslint@54c0953) fix: cleanup typos ([#15939](eslint/eslint#15939)) (Nick Schonning) - [`845a7af`](eslint/eslint@845a7af) fix: typo ocatal -> octal ([#15940](eslint/eslint#15940)) (Nick Schonning) #### Documentation - [`b915018`](eslint/eslint@b915018) docs: Update website UI to latest ([#15944](eslint/eslint#15944)) (Nicholas C. Zakas) - [`f0bb609`](eslint/eslint@f0bb609) docs: Update Exponentiation operator MDN link ([#15960](eslint/eslint#15960)) (Pranjal Jain) - [`baa0153`](eslint/eslint@baa0153) docs: Use correct past tense "left" instead of "leaved" ([#15950](eslint/eslint#15950)) (Frederik Braun) - [`1351a9b`](eslint/eslint@1351a9b) docs: Add Resources section to rule pages ([#15901](eslint/eslint#15901)) (Nicholas C. Zakas) - [`68cf0fb`](eslint/eslint@68cf0fb) docs: cleanup typos ([#15936](eslint/eslint#15936)) (Nick Schonning) - [`13b62ae`](eslint/eslint@13b62ae) docs: use-dart-sass instead of node-sass ([#15912](eslint/eslint#15912)) (Deepshika S) - [`c81c5d6`](eslint/eslint@c81c5d6) docs: add social media links ([#15920](eslint/eslint#15920)) (Deepshika S) - [`0d6a50b`](eslint/eslint@0d6a50b) docs: fix openjs link ([#15917](eslint/eslint#15917)) (Amaresh S M) - [`54910f5`](eslint/eslint@54910f5) docs: display version in mobile view ([#15909](eslint/eslint#15909)) (Amaresh S M) #### Chores - [`da694b9`](eslint/eslint@da694b9) chore: avoid theme flashes ([#15927](eslint/eslint#15927)) (Strek) - [`f836743`](eslint/eslint@f836743) chore: Use build hook for docs deploy ([#15945](eslint/eslint#15945)) (Nicholas C. Zakas) - [`ce035e5`](eslint/eslint@ce035e5) test: cleanup typos ([#15937](eslint/eslint#15937)) (Nick Schonning) - [`10249ad`](eslint/eslint@10249ad) chore: use addEventListener instead of addListener ([#15923](eslint/eslint#15923)) (Amaresh S M) - [`5f5c1fb`](eslint/eslint@5f5c1fb) chore: lint eleventy config file ([#15904](eslint/eslint#15904)) (Milos Djermanovic) - [`8513d37`](eslint/eslint@8513d37) chore: update Rule typedefs ([#15915](eslint/eslint#15915)) (Milos Djermanovic) - [`55534f1`](eslint/eslint@55534f1) test: ensure no-restricted-imports works with NodeJS imports ([#15907](eslint/eslint#15907)) (Nick Mazuk) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1395 Reviewed-by: 6543 <6543@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

docs: Update website UI to latest

6cca824

eslint-github-bot bot added documentation Relates to ESLint's documentation triage An ESLint team member will look at this issue soon labels May 30, 2022

mdjermanovic reviewed May 30, 2022

View reviewed changes

docs/src/assets/scss/utilities.scss Outdated Show resolved Hide resolved

This was referenced May 30, 2022

chore: reduce cumulative layout shifts #15926

Closed

chore: fix docs search option in mobile view #15910

Closed

mdjermanovic reviewed May 30, 2022

View reviewed changes

docs/src/_includes/components/nav-version-switcher.html Outdated Show resolved Hide resolved

mdjermanovic reviewed May 30, 2022

View reviewed changes

docs/src/_includes/components/nav-version-switcher.html Outdated Show resolved Hide resolved

docs/src/_includes/components/nav-version-switcher.html Outdated Show resolved Hide resolved

mdjermanovic reviewed May 31, 2022

View reviewed changes

docs/src/_includes/components/docs-toc.html Outdated Show resolved Hide resolved

Update docs/src/_includes/components/docs-toc.html

cd4933e

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

mdjermanovic reviewed May 31, 2022

View reviewed changes

docs/src/_includes/components/navigation.html Outdated Show resolved Hide resolved

nzakas and others added 4 commits May 30, 2022 17:49

Update docs/src/_includes/components/nav-version-switcher.html

54e337e

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

Update docs/src/_includes/components/nav-version-switcher.html

5004842

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

Update docs/src/_includes/components/nav-version-switcher.html

2b6c741

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

Update docs/src/_includes/components/navigation.html

83290e4

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

Fix hidden attribute

173d6a7

mdjermanovic reviewed May 31, 2022

View reviewed changes

mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels May 31, 2022

nzakas and others added 6 commits May 31, 2022 17:24

Update docs/src/_includes/components/theme-switcher.html

08bb73a

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

Update docs/src/_includes/components/theme-switcher.html

7cc8511

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

Update docs/src/assets/js/focus-visible.js

79084a4

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

Update docs/src/assets/js/main.js

5c98724

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

Update docs/src/assets/js/components-index.js

ffaa683

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

Update docs/src/assets/js/main.js

04200d7

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

Update docs/src/assets/js/main.js

ae3004a

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

mdjermanovic mentioned this pull request Jun 1, 2022

docs: align footer-tablet view #15918

Closed

9 tasks

mdjermanovic approved these changes Jun 3, 2022

View reviewed changes

mdjermanovic merged commit b915018 into main Jun 3, 2022

mdjermanovic deleted the docs-ui-update branch June 3, 2022 21:14

sync-by-unito bot mentioned this pull request Jul 1, 2022

build(deps-dev): bump eslint from 7.32.0 to 8.18.0 numbersprotocol/capture-lite#1769

Closed

eslint-github-bot bot locked and limited conversation to collaborators Dec 1, 2022

eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: Update website UI to latest #15944

docs: Update website UI to latest #15944

nzakas commented May 30, 2022

netlify bot commented May 30, 2022 •

edited

mdjermanovic left a comment

mdjermanovic commented May 31, 2022

nzakas commented May 31, 2022

mdjermanovic May 31, 2022

nzakas Jun 3, 2022

mdjermanovic Jun 3, 2022

mdjermanovic commented May 31, 2022

docs: Update website UI to latest #15944

docs: Update website UI to latest #15944

Conversation

nzakas commented May 30, 2022

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

netlify bot commented May 30, 2022 • edited

✅ Deploy Preview for docs-eslint ready!

mdjermanovic left a comment

Choose a reason for hiding this comment

mdjermanovic commented May 31, 2022

nzakas commented May 31, 2022

mdjermanovic May 31, 2022

Choose a reason for hiding this comment

nzakas Jun 3, 2022

Choose a reason for hiding this comment

mdjermanovic Jun 3, 2022

Choose a reason for hiding this comment

mdjermanovic commented May 31, 2022

netlify bot commented May 30, 2022 •

edited