New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Link to blog post in no-constant-binary-expression #16112
Conversation
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
The docs site build is failing due to a missing entry for the new link in docs/src/_data/further_reading_links.json We set up this to be automatically inserted on pre-commit, but it seems that it didn't work in your environment. To fix this, you can manually run the script: node tools/fetch-docs-links.js docs/src/rules/no-constant-binary-expression.md and then commit |
I thought the change would be simple so I made it using the GitHub UI. Looks like it's more complicated than that. |
Yeah, there’s a script that fetches all the info about the URL to display in the page. That runs on precommit so people can’t skip it. Clearly we forgot about GitHub UI-based edits. 😅 You can either update the branch from your CLI or we can close this. |
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.19.0` -> `8.20.0`](https://renovatebot.com/diffs/npm/eslint/8.19.0/8.20.0) | --- ### Release Notes <details> <summary>eslint/eslint</summary> ### [`v8.20.0`](https://github.com/eslint/eslint/releases/tag/v8.20.0) [Compare Source](eslint/eslint@v8.19.0...v8.20.0) #### Features - [`ca83178`](eslint/eslint@ca83178) feat: catch preprocess errors ([#​16105](eslint/eslint#16105)) (JounQin) #### Bug Fixes - [`30be0ed`](eslint/eslint@30be0ed) fix: no-warning-comments rule escapes special RegEx characters in terms ([#​16090](eslint/eslint#16090)) (Lachlan Hunt) - [`bfe5e88`](eslint/eslint@bfe5e88) fix: ignore spacing before `]` and `}` in comma-spacing ([#​16113](eslint/eslint#16113)) (Milos Djermanovic) #### Documentation - [`845c4f4`](eslint/eslint@845c4f4) docs: Add website team details ([#​16115](eslint/eslint#16115)) (Nicholas C. Zakas) - [`5a0dfdb`](eslint/eslint@5a0dfdb) docs: Link to blog post in no-constant-binary-expression ([#​16112](eslint/eslint#16112)) (Jordan Eldredge) - [`bc692a9`](eslint/eslint@bc692a9) docs: remove install command ([#​16084](eslint/eslint#16084)) (Strek) - [`49ca3f0`](eslint/eslint@49ca3f0) docs: don't show toc when content not found ([#​16095](eslint/eslint#16095)) (Amaresh S M) - [`ba19e3f`](eslint/eslint@ba19e3f) docs: enhance 404 page UI ([#​16097](eslint/eslint#16097)) (Amaresh S M) - [`a75d3b4`](eslint/eslint@a75d3b4) docs: remove unused meta.docs.category field in working-with-rules page ([#​16109](eslint/eslint#16109)) (Brandon Scott) - [`cdc0206`](eslint/eslint@cdc0206) docs: add formatters page edit link ([#​16094](eslint/eslint#16094)) (Amaresh S M) - [`4d1ed22`](eslint/eslint@4d1ed22) docs: preselect default theme ([#​16098](eslint/eslint#16098)) (Strek) - [`4b79612`](eslint/eslint@4b79612) docs: add missing correct/incorrect containers ([#​16087](eslint/eslint#16087)) (Milos Djermanovic) - [`09f6acb`](eslint/eslint@09f6acb) docs: fix UI bug on rules index and details pages ([#​16082](eslint/eslint#16082)) (Deepshika S) - [`f5db264`](eslint/eslint@f5db264) docs: remove remaining duplicate rule descriptions ([#​16093](eslint/eslint#16093)) (Milos Djermanovic) - [`32a6b2a`](eslint/eslint@32a6b2a) docs: Add scroll behaviour smooth ([#​16056](eslint/eslint#16056)) (Amaresh S M) #### Chores - [`bbf8df4`](eslint/eslint@bbf8df4) chore: Mark autogenerated release blog post as draft ([#​16130](eslint/eslint#16130)) (Nicholas C. Zakas) - [`eee4306`](eslint/eslint@eee4306) chore: update internal lint dependencies ([#​16088](eslint/eslint#16088)) (Bryan Mishkin) - [`9615a42`](eslint/eslint@9615a42) chore: update formatter examples template to avoid markdown lint error ([#​16085](eslint/eslint#16085)) (Milos Djermanovic) - [`62541ed`](eslint/eslint@62541ed) chore: fix markdown linting error ([#​16083](eslint/eslint#16083)) (唯然) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTcuMSIsInVwZGF0ZWRJblZlciI6IjMyLjExNy4xIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1466 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
What changes did you make? (Give an overview)
Link to the blog post about no-constant-binary-expression in that rule's docs
Is there anything you'd like reviewers to focus on?
Nope