Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: [new config system] Files outside cwd were not found #16413

Closed
1 task
Tracked by #13481
mdjermanovic opened this issue Oct 12, 2022 · 1 comment · Fixed by #16449
Closed
1 task
Tracked by #13481

Bug: [new config system] Files outside cwd were not found #16413

mdjermanovic opened this issue Oct 12, 2022 · 1 comment · Fixed by #16449
Assignees
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly repro:yes
Projects

Comments

@mdjermanovic
Copy link
Member

Environment

Node version: v16.14.0
npm version: v8.3.1
Local ESLint version: main branch
Global ESLint version: Not found
Operating System: win32 10.0.19044

What parser are you using?

Default (Espree)

What did you do?

my-app/
├── a.js
├── eslint.config.js
└── foo/
// eslint.config.js
module.exports = [];

Command:

cd foo && eslint "../*.js" -f tap

What did you expect to happen?

TAP version 13
1..2
ok 1 - D:\tmp\my-app\a.js
ok 2 - D:\tmp\my-app\eslint.config.js

This was the actual result before #16369. This is also the actual result when eslintrc config is used.

What actually happened?

Oops! Something went wrong! :(

ESLint: 8.25.0

No files matching the pattern "../*.js" were found.
Please check for typing mistakes in the pattern.

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response

@mdjermanovic mdjermanovic added bug ESLint is working incorrectly repro:needed labels Oct 12, 2022
@eslint-github-bot eslint-github-bot bot added this to Needs Triage in Triage Oct 12, 2022
@mdjermanovic mdjermanovic changed the title Bug: [new config system] Bug: [new config system] Files outside cwd were not found Oct 12, 2022
@nzakas nzakas mentioned this issue Oct 13, 2022
69 tasks
@nzakas nzakas self-assigned this Oct 17, 2022
@nzakas nzakas added accepted There is consensus among the team that this change meets the criteria for inclusion repro:yes and removed repro:needed labels Oct 17, 2022
@nzakas nzakas moved this from Needs Triage to Ready to Implement in Triage Oct 17, 2022
@nzakas
Copy link
Member

nzakas commented Oct 17, 2022

Working on this.

nzakas added a commit that referenced this issue Oct 20, 2022
nzakas added a commit that referenced this issue Oct 21, 2022
Triage automation moved this from Ready to Implement to Complete Oct 21, 2022
mdjermanovic pushed a commit that referenced this issue Oct 21, 2022
* fix: Ensure that glob patterns are matched correctly.

Fixes #16413
Fixes #16299

* Fix cli tests

* Upgrade config-array to fix globbing issues
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Apr 20, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly repro:yes
Projects
Archived in project
Triage
Complete
Development

Successfully merging a pull request may close this issue.

2 participants