Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: UI inconsistency in site header #16452

Closed
1 task done
chenxsan opened this issue Oct 22, 2022 · 1 comment · Fixed by #16464
Closed
1 task done

Bug: UI inconsistency in site header #16452

chenxsan opened this issue Oct 22, 2022 · 1 comment · Fixed by #16464
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly repro:yes
Projects
Triage

Comments

@chenxsan
Copy link
Contributor

chenxsan commented Oct 22, 2022 •
edited

Environment

Node version: n/a
npm version: n/a
Local ESLint version: n/a
Global ESLint version: n/a
Operating System: n/a

What parser are you using?

Other

What did you do?

Per #16403 (comment)

The desktop version of eslint site has this border above its site header spanning the full width of the viewport:

But pages under the docs are exception:

What did you expect to happen?

I would expect the docs one to keep consistent with others.

E.g.,

What actually happened?

Pages under docs don't share a consistent UI with others.

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

Sorry for breaking the mobile site with #16403, I should be more careful when editing those traditional css rules :)
@chenxsan chenxsan added bug ESLint is working incorrectly repro:needed labels Oct 22, 2022
@eslint-github-bot eslint-github-bot bot added this to Needs Triage in Triage Oct 22, 2022
@mnosov622
Copy link

Hello !

I would love to work on this issue. Could you please assign it to, me ?

@Tanujkanti4441 Tanujkanti4441 mentioned this issue Oct 27, 2022
Merged
1 task
@mdjermanovic mdjermanovic linked a pull request Nov 5, 2022 that will close this issue
docs: fix Header UI inconsistency #16464
Merged
1 task
@snitin315 snitin315 moved this from Needs Triage to Ready to Implement in Triage Nov 6, 2022
@snitin315 snitin315 added accepted There is consensus among the team that this change meets the criteria for inclusion repro:yes and removed repro:needed labels Nov 6, 2022
@snitin315 snitin315 moved this from Ready to Implement to Pull Request Opened in Triage Nov 6, 2022
Triage automation moved this from Pull Request Opened to Complete Nov 17, 2022
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators May 17, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly repro:yes
Projects
Triage
Archived in project
Triage
Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fix Header UI inconsistency
3 participants
@chenxsan @snitin315 @mnosov622