Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add documentation for "argsIgnorePattern" to rule "no-unused-vars" #16616

Closed
1 task done
L3XAWeasel opened this issue Dec 5, 2022 · 3 comments
Closed
1 task done

Docs: Add documentation for "argsIgnorePattern" to rule "no-unused-vars" #16616

L3XAWeasel opened this issue Dec 5, 2022 · 3 comments
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint triage An ESLint team member will look at this issue soon
Projects
Triage

Comments

@L3XAWeasel
Copy link

ESLint version

v8.29.0

What problem do you want to solve?

Currently on https://eslint.org/docs/latest/rules/no-unused-vars the documentation for the "argsIgnorePattern" option on the respective rule is missing, even though the options exists.

What do you think is the correct solution?

Add the documentation in the "style" of the present documentation of "varsgnorePattern" of the "no-unsed-vars" rule.

Participation

  • I am willing to submit a pull request for this change.

Additional comments

Technically this also affects the respective typescript rule (@typescript-eslint/no-unused-vars) which links the eslint documentation.
@L3XAWeasel L3XAWeasel added core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint triage An ESLint team member will look at this issue soon labels Dec 5, 2022
@eslint-github-bot eslint-github-bot bot added this to Needs Triage in Triage Dec 5, 2022
@mdjermanovic mdjermanovic moved this from Needs Triage to Triaging in Triage Dec 5, 2022
@mdjermanovic
Copy link
Member

Hi @L3XAWeasel, thanks for the issue!

Isn't the option documented here:

https://eslint.org/docs/latest/rules/no-unused-vars#argsignorepattern

mdjermanovic added a commit that referenced this issue Dec 7, 2022
@mdjermanovic
docs: reorder options in no-unused-vars
595495a 
Refs #16616
@mdjermanovic mdjermanovic mentioned this issue Dec 7, 2022
Merged
1 task
@mdjermanovic
Copy link
Member

I think the order of the options was confusing. #16625 should fix that.

nzakas pushed a commit that referenced this issue Dec 8, 2022
@mdjermanovic
docs: reorder options in no-unused-vars (#16625)
75276c9 
Refs #16616
@nzakas
Copy link
Member

nzakas commented Dec 9, 2022

It seems like this was addressed in the merged PR, so closing.

@nzakas nzakas closed this as completed Dec 9, 2022
Triage automation moved this from Triaging to Complete Dec 9, 2022
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jun 8, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint triage An ESLint team member will look at this issue soon
Projects
Triage
Archived in project
Triage
Complete
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nzakas @mdjermanovic @L3XAWeasel