docs: Removed the second object instance for the "no-new" rule #17020

sir-kain · 2023-03-26T05:30:16Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request?

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Delete the second unnecessary instance.

linux-foundation-easycla · 2023-03-26T05:30:22Z

The committers listed above are authorized under a signed CLA.

✅ login: sir-kain / name: Ahmadou Waly NDIAYE (7041663)

netlify · 2023-03-26T05:30:23Z

✅ Deploy Preview for docs-eslint ready!

Name	Link
🔨 Latest commit	`4027099`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/6428e2b653a18b00085e8f09
😎 Deploy Preview	https://deploy-preview-17020--docs-eslint.netlify.app/rules/no-new
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

fasttime · 2023-03-26T09:47:17Z

docs/src/rules/no-new.md

@@ -42,8 +42,6 @@ Examples of **correct** code for this rule:
 /*eslint no-new: "error"*/

 var thing = new Thing();
-
-Thing();


Thanks for the PR @sir-kain, but I think this line was added intentionally to show that the rule does not report a problem if a constructor is called without new.

Thank you. In this case, would it be better to provide 2 separate examples to avoid confusion? (As we already do with lines-between-class-members rule)

For instance:

Examples of correct code for this rule:

/*eslint no-new: "error"*/ var thing = new Thing();

Examples of additional correct code for this rule:

/*eslint no-new: "error"*/ Thing();

Thank you. In this case, would it be better to provide 2 separate examples to avoid confusion? (As we already do with lines-between-class-members rule)

My feeling is that Thing(); alone does not make it immediately clear that a constructor is being invoked. This becomes evident when looking at the previous line. If the examples are split then there should be some additional explanation/context to clarify.

I think the best solution to avoid confusion, as these two examples are not related to each other, would be to rename Thing(); to something else. For example, Foo();.

In the incorrect example, the class is named Thing.

This example aims to show that function calls are not reported even if the callee looks like a constructor, so Foo(); would be fine.

PR updated.

fasttime

LGTM!

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.37.0` -> `8.39.0`](https://renovatebot.com/diffs/npm/eslint/8.37.0/8.39.0) | --- ### Release Notes <details> <summary>eslint/eslint</summary> ### [`v8.39.0`](https://github.com/eslint/eslint/releases/tag/v8.39.0) [Compare Source](eslint/eslint@v8.38.0...v8.39.0) #### Features - [`3f7af9f`](eslint/eslint@3f7af9f) feat: Implement `SourceCode#markVariableAsUsed()` ([#17086](eslint/eslint#17086)) (Nicholas C. Zakas) #### Documentation - [`6987dc5`](eslint/eslint@6987dc5) docs: Fix formatting in Custom Rules docs ([#17097](eslint/eslint#17097)) (Milos Djermanovic) - [`4ee92e5`](eslint/eslint@4ee92e5) docs: Update README (GitHub Actions Bot) - [`d8e9887`](eslint/eslint@d8e9887) docs: Custom Rules cleanup/expansion ([#16906](eslint/eslint#16906)) (Ben Perlmutter) - [`1fea279`](eslint/eslint@1fea279) docs: Clarify how to add to tsc agenda ([#17084](eslint/eslint#17084)) (Nicholas C. Zakas) - [`970ef1c`](eslint/eslint@970ef1c) docs: Update triage board location (Nicholas C. Zakas) - [`6d8bffd`](eslint/eslint@6d8bffd) docs: Update README (GitHub Actions Bot) #### Chores - [`60a6f26`](eslint/eslint@60a6f26) chore: upgrade [@eslint/js](https://github.com/eslint/js)[@8](https://github.com/8).39.0 ([#17102](eslint/eslint#17102)) (Milos Djermanovic) - [`d5ba5c0`](eslint/eslint@d5ba5c0) chore: package.json update for [@eslint/js](https://github.com/eslint/js) release (ESLint Jenkins) - [`f57eff2`](eslint/eslint@f57eff2) ci: run tests on Node.js v20 ([#17093](eslint/eslint#17093)) (Nitin Kumar) - [`9d1b8fc`](eslint/eslint@9d1b8fc) perf: Binary search in token store `utils.search` ([#17066](eslint/eslint#17066)) (Francesco Trotta) - [`07a4435`](eslint/eslint@07a4435) chore: Add request for minimal repro to bug report ([#17081](eslint/eslint#17081)) (Nicholas C. Zakas) - [`eac4943`](eslint/eslint@eac4943) refactor: remove unnecessary use of `SourceCode#getAncestors` in rules ([#17075](eslint/eslint#17075)) (Milos Djermanovic) - [`0a7b60a`](eslint/eslint@0a7b60a) chore: update description of `SourceCode#getDeclaredVariables` ([#17072](eslint/eslint#17072)) (Milos Djermanovic) - [`6e2df71`](eslint/eslint@6e2df71) chore: remove unnecessary references to the LICENSE file ([#17071](eslint/eslint#17071)) (Milos Djermanovic) ### [`v8.38.0`](https://github.com/eslint/eslint/releases/tag/v8.38.0) [Compare Source](eslint/eslint@v8.37.0...v8.38.0) #### Features - [`a1d561d`](eslint/eslint@a1d561d) feat: Move getDeclaredVariables and getAncestors to SourceCode ([#17059](eslint/eslint#17059)) (Nicholas C. Zakas) #### Bug Fixes - [`1c1ece2`](eslint/eslint@1c1ece2) fix: do not report on `RegExp(...args)` in `require-unicode-regexp` ([#17037](eslint/eslint#17037)) (Francesco Trotta) #### Documentation - [`7162d34`](eslint/eslint@7162d34) docs: Mention new config system is complete ([#17068](eslint/eslint#17068)) (Nicholas C. Zakas) - [`0fd6bb2`](eslint/eslint@0fd6bb2) docs: Update README (GitHub Actions Bot) - [`c83531c`](eslint/eslint@c83531c) docs: Update/remove external links, eg. point to `eslint-community` ([#17061](eslint/eslint#17061)) (Pelle Wessman) - [`a3aa6f5`](eslint/eslint@a3aa6f5) docs: Clarify `no-div-regex` rule docs ([#17051](eslint/eslint#17051)) (Francesco Trotta) - [`b0f11cf`](eslint/eslint@b0f11cf) docs: Update README (GitHub Actions Bot) - [`da8d52a`](eslint/eslint@da8d52a) docs: Update the second object instance for the "no-new" rule ([#17020](eslint/eslint#17020)) (Ahmadou Waly NDIAYE) - [`518130a`](eslint/eslint@518130a) docs: switch language based on current path ([#16687](eslint/eslint#16687)) (Percy Ma) - [`24206c4`](eslint/eslint@24206c4) docs: Update README (GitHub Actions Bot) #### Chores - [`59ed060`](eslint/eslint@59ed060) chore: upgrade [@eslint/js](https://github.com/eslint/js)[@8](https://github.com/8).38.0 ([#17069](eslint/eslint#17069)) (Milos Djermanovic) - [`88c0898`](eslint/eslint@88c0898) chore: package.json update for [@eslint/js](https://github.com/eslint/js) release (ESLint Jenkins) - [`cf682d2`](eslint/eslint@cf682d2) refactor: simplify new-parens rule schema ([#17060](eslint/eslint#17060)) (MHO) - [`0dde022`](eslint/eslint@0dde022) ci: bump actions/add-to-project from 0.4.1 to 0.5.0 ([#17055](eslint/eslint#17055)) (dependabot\[bot]) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1852 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

mdjermanovic · 2023-06-08T14:17:14Z

@sir-kain could you please submit this same change again, in a new PR, as we had to undo it due to #17225.

snitin315 · 2023-06-10T02:56:14Z

Re-submitted in #17264

docs: Removed the second object instance for the "no-new" rule

7041663

sir-kain requested a review from a team as a code owner March 26, 2023 05:30

eslint-github-bot bot added the documentation Relates to ESLint's documentation label Mar 26, 2023

fasttime reviewed Mar 26, 2023

View reviewed changes

fasttime added the evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion label Mar 26, 2023

docs: re-define the function name

4027099

fasttime approved these changes Apr 2, 2023

View reviewed changes

fasttime added rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Apr 2, 2023

fasttime merged commit da8d52a into eslint:main Apr 2, 2023
21 checks passed

github-actions bot mentioned this pull request May 2, 2023

Upgraded some dependencies - Attempt 2 AurorNZ/report-updated-dependencies#638

Merged

mdjermanovic mentioned this pull request May 27, 2023

Bug: Documentation licensed under non-OSS compatible license #17225

Closed

snitin315 mentioned this pull request Jun 10, 2023

docs: resubmit no-new rule documentation #17264

Merged

1 task

eslint-github-bot bot locked and limited conversation to collaborators Sep 30, 2023

eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: Removed the second object instance for the "no-new" rule #17020

docs: Removed the second object instance for the "no-new" rule #17020

sir-kain commented Mar 26, 2023

linux-foundation-easycla bot commented Mar 26, 2023 •

edited

netlify bot commented Mar 26, 2023 •

edited

fasttime Mar 26, 2023

sir-kain Mar 26, 2023

fasttime Mar 27, 2023

mdjermanovic Mar 27, 2023

sir-kain Mar 27, 2023

mdjermanovic Apr 1, 2023

sir-kain Apr 2, 2023 •

edited

fasttime left a comment

mdjermanovic commented Jun 8, 2023

snitin315 commented Jun 10, 2023

docs: Removed the second object instance for the "no-new" rule #17020

docs: Removed the second object instance for the "no-new" rule #17020

Conversation

sir-kain commented Mar 26, 2023

Prerequisites checklist

What is the purpose of this pull request?

What changes did you make? (Give an overview)

linux-foundation-easycla bot commented Mar 26, 2023 • edited

netlify bot commented Mar 26, 2023 • edited

✅ Deploy Preview for docs-eslint ready!

fasttime Mar 26, 2023

Choose a reason for hiding this comment

sir-kain Mar 26, 2023

Choose a reason for hiding this comment

Examples of correct code for this rule:

Examples of additional correct code for this rule:

fasttime Mar 27, 2023

Choose a reason for hiding this comment

mdjermanovic Mar 27, 2023

Choose a reason for hiding this comment

sir-kain Mar 27, 2023

Choose a reason for hiding this comment

mdjermanovic Apr 1, 2023

Choose a reason for hiding this comment

sir-kain Apr 2, 2023 • edited

Choose a reason for hiding this comment

fasttime left a comment

Choose a reason for hiding this comment

mdjermanovic commented Jun 8, 2023

snitin315 commented Jun 10, 2023

linux-foundation-easycla bot commented Mar 26, 2023 •

edited

netlify bot commented Mar 26, 2023 •

edited

sir-kain Apr 2, 2023 •

edited