Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain how to include predefined globals #17114

Merged
merged 4 commits into from Apr 24, 2023
Merged

docs: explain how to include predefined globals #17114

merged 4 commits into from Apr 24, 2023

Conversation

mlwyatt
Copy link
Contributor

@mlwyatt mlwyatt commented Apr 24, 2023

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

I've added a note about how to enable native globals as discussed in #17101 (reply in thread)

Is there anything you'd like reviewers to focus on?

I think the wording is pretty clear, but let me know if not.

@mlwyatt mlwyatt requested a review from a team as a code owner April 24, 2023 13:07
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Apr 24, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 24, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify
Copy link

netlify bot commented Apr 24, 2023

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 3186a2f
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/64469a1dbd29cf0008fa811d
😎 Deploy Preview https://deploy-preview-17114--docs-eslint.netlify.app/use/configure/configuration-files-new
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Co-authored-by: Francesco Trotta <github@fasttime.org>
@mlwyatt mlwyatt requested a review from fasttime April 24, 2023 15:03
@amareshsm amareshsm added the accepted There is consensus among the team that this change meets the criteria for inclusion label Apr 24, 2023
Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Leaving it open for others to verify once.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving it open for @fasttime to verify.

@fasttime fasttime changed the title docs: explain how to include native globals docs: explain how to include predefined globals Apr 24, 2023
@fasttime
Copy link
Member

Thanks @mlwyatt! I've changed "native globals" to "predefined globals" in the title because some environments define globals that are not native (e.g. mocha's describe, it, etc.).

Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fasttime fasttime merged commit 4a352a9 into eslint:main Apr 24, 2023
21 of 22 checks passed
@mlwyatt mlwyatt deleted the native_globals branch April 24, 2023 20:00
@mdjermanovic
Copy link
Member

@mlwyatt could you please submit the same changes again, in a new PR, as we had to undo them due to #17225.

@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Oct 22, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants