You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Adds a findConfigFile() method to FlatESLint. The purpose of this method is to return the location of the config file this FlatESLint instance will use as the basis for its configuration without actually loading the file.
Is there anything you'd like reviewers to focus on?
I didn't include any caching for the config file path as I don't see this as a common enough use case to optimize what is typically a very fast search. Let me know if you think differently.
@nzakas in the default mode (overrideConfigFile constructor option is not a string or true), findConfigFile() throws an error if it doesn't find an eslint.config.js file. I assumed this was desired behavior, but per the example from #17129 (comment) where it returns a falsy value that doesn't seem to be the case, so just to double check with you - is throwing an error in mentioned case the desired behavior?
in the default mode (overrideConfigFile constructor option is not a string or true), findConfigFile() throws an error if it doesn't find an eslint.config.js file. I assumed this was desired behavior, but per the example from #17129 (comment) where it returns a falsy value that doesn't seem to be the case, so just to double check with you - is throwing an error in mentioned case the desired behavior?
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
acceptedThere is consensus among the team that this change meets the criteria for inclusionarchived due to ageThis issue has been archived; please open a new issue for any further discussionfeatureThis change adds a new feature to ESLint
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
amareshsm
added
the
accepted
eslint-github-bot
bot
added
the
archived due to age
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Adds a
findConfigFile()method toFlatESLint. The purpose of this method is to return the location of the config file thisFlatESLintinstance will use as the basis for its configuration without actually loading the file.Fixes #17046
Is there anything you'd like reviewers to focus on?
I didn't include any caching for the config file path as I don't see this as a common enough use case to optimize what is typically a very fast search. Let me know if you think differently.