Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update triage process description #17157

Merged
merged 1 commit into from May 9, 2023
Merged

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented May 5, 2023

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Updates the issue triage process to discuss the new Priority and Impact fields.

Is there anything you'd like reviewers to focus on?

Does the description make sense?

@nzakas nzakas requested a review from a team as a code owner May 5, 2023 22:04
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label May 5, 2023
@netlify
Copy link

netlify bot commented May 5, 2023

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 7efddd3
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/64557d622a7a2800088c4f76
😎 Deploy Preview https://deploy-preview-17157--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add some common examples - such as only a certain rule-related feature request/bug should belong to which level, this can help us better unify the standard. :)

@nzakas
Copy link
Member Author

nzakas commented May 8, 2023

@aladdin-add I think we need to run with the process a bit to figure out specific examples.

Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. waiting @mdjermanovic and other members to review before merging.

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label May 9, 2023
@mdjermanovic mdjermanovic merged commit 7f183e0 into main May 9, 2023
22 checks passed
@mdjermanovic mdjermanovic deleted the triage-docs-update branch May 9, 2023 18:30
@snitin315
Copy link
Contributor

Re-submitted in #17266

@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Nov 6, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants