Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: locateConfigFileToUse returns an Error object #17159

Merged

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented May 6, 2023

followup of #17151 (comment)

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ x] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@aladdin-add aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing labels May 6, 2023
@aladdin-add aladdin-add requested a review from a team as a code owner May 6, 2023 01:51
@netlify
Copy link

netlify bot commented May 6, 2023

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 0f87ea2
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6455b29edf6f7700088febf0

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will leave it open for others to review it.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 4caa344 into eslint:main May 7, 2023
21 of 22 checks passed
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Nov 4, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants