Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix return type of findFlatConfigFile #17161

Merged
merged 1 commit into from May 8, 2023
Merged

chore: Fix return type of findFlatConfigFile #17161

merged 1 commit into from May 8, 2023

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Fixes return type in JSDoc of internal function findFlatConfigFile. When it doesn't find a file, find-up returns undefined, not null.

What changes did you make? (Give an overview)

Fixed JSDoc.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing labels May 7, 2023
@mdjermanovic mdjermanovic requested a review from a team as a code owner May 7, 2023 17:10
@netlify
Copy link

netlify bot commented May 7, 2023 •
edited

✅ Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 73507c9
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6457db77a5fa930008603e9a

snitin315
snitin315 approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Leaving this open until we determine wether a patch release is required or not.

nzakas
nzakas approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nzakas nzakas merged commit b1516db into main May 8, 2023
22 checks passed
@nzakas nzakas deleted the findflatconfigfile-returntype branch May 8, 2023 21:23
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Nov 5, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nzakas nzakas nzakas approved these changes

@aladdin-add aladdin-add aladdin-add approved these changes

@snitin315 snitin315 snitin315 approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mdjermanovic @nzakas @aladdin-add @snitin315