test: Add `FlatESLint` tests with missing config files #17164

mdjermanovic · 2023-05-08T09:43:20Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

While reviewing #17142, I noticed we didn't have tests where eslint.config.js is missing. In particular, a test that would confirm that FlatESLint lint methods should throw if a config file was not found.

What changes did you make? (Give an overview)

Added a few tests for FlatESLint#lintText() and FlatESLint#lintFiles().

Is there anything you'd like reviewers to focus on?

netlify · 2023-05-08T09:43:28Z

✅ Deploy Preview for docs-eslint ready!

Name	Link
🔨 Latest commit	`1b2058d`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/645cbc959b7b950008481c63
😎 Deploy Preview	https://deploy-preview-17164--docs-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

nzakas

The tests look good. Just left a couple suggestions.

nzakas · 2023-05-08T20:57:21Z

tests/lib/eslint/flat-eslint.js

+                cwd: getFixturePath(""),
+                overrideConfigFile: "does-not-exist.js"
+            });
+            await assert.rejects(() => eslint.lintText("var foo = 'bar';"));


Should we add the message check here too?

Suggested change

await assert.rejects(() => eslint.lintText("var foo = 'bar';"));

await assert.rejects(() => eslint.lintText("var foo = 'bar';"), /Could not find config file/u);

This is a system error thrown by fs.stat():

Error: ENOENT: no such file or directory, stat 'path/to/temp/eslint/fixtures/does-not-exist.js'.

I wanted to avoid checking error messages that we don't generate.

Perhaps /ENOENT/u?

Maybe {code: "ENOENT"}? Looks more accurate to me. We can even add a checker function that asserts the code and uses a regex on the message property. (docs: https://nodejs.org/api/assert.html#assertrejectsasyncfn-error-message)

I think anything that checks the expected error message is fine. I just want to make sure we are getting the error we're expecting. I'm agnostic as to the approach.

Added { code: "ENOENT" }, thanks for the suggestion!

nzakas · 2023-05-08T21:00:01Z

tests/lib/eslint/flat-eslint.js

+                cwd: getFixturePath(),
+                overrideConfigFile: "does-not-exist.js"
+            });
+            await assert.rejects(() => eslint.lintFiles("undef*.js"));


Same, do we want to check the message?

Suggested change

await assert.rejects(() => eslint.lintFiles("undef*.js"));

await assert.rejects(() => eslint.lintFiles("undef*.js"), /Could not find config file/u);

I concur. We should check the error code and message when viable as any error can mask actual errors code (working or test).

Added { code: "ENOENT" }

BYK

LGTM but will leave approving to @nzakas for this as I'm not sure if he wanted an explicit check on the message (and not just the code)

aladdin-add

LGTM.

github-actions · 2023-05-22T22:31:29Z

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

Rec0iL99 · 2023-05-22T22:57:53Z

Not stale. All reviews have been resolved. Waiting for @nzakas's final review.

nzakas

LGTM. Thanks

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.41.0` -> `8.42.0`](https://renovatebot.com/diffs/npm/eslint/8.41.0/8.42.0) | --- ### Release Notes <details> <summary>eslint/eslint</summary> ### [`v8.42.0`](https://github.com/eslint/eslint/releases/tag/v8.42.0) [Compare Source](eslint/eslint@v8.41.0...v8.42.0) #### Features - [`b8448ff`](eslint/eslint@b8448ff) feat: correct no-useless-return behaviour in try statements ([#16996](eslint/eslint#16996)) (Nitin Kumar) #### Bug Fixes - [`a589636`](eslint/eslint@a589636) fix: Config with `ignores` and without `files` should not always apply ([#17181](eslint/eslint#17181)) (Milos Djermanovic) - [`c4fad17`](eslint/eslint@c4fad17) fix: Correct ignore message for "node_modules" subfolders ([#17217](eslint/eslint#17217)) (Francesco Trotta) #### Documentation - [`01d7142`](eslint/eslint@01d7142) docs: Update README (GitHub Actions Bot) - [`e5182b7`](eslint/eslint@e5182b7) docs: Update README (GitHub Actions Bot) #### Chores - [`6ca5b7c`](eslint/eslint@6ca5b7c) chore: upgrade [@eslint/js](https://github.com/eslint/js)[@8](https://github.com/8).42.0 ([#17236](eslint/eslint#17236)) (Milos Djermanovic) - [`67fc5e7`](eslint/eslint@67fc5e7) chore: package.json update for [@eslint/js](https://github.com/eslint/js) release (ESLint Jenkins) - [`0892412`](eslint/eslint@0892412) refactor: remove `Identifier` listener in no-irregular-whitespace ([#17235](eslint/eslint#17235)) (Milos Djermanovic) - [`f67d298`](eslint/eslint@f67d298) test: Add `FlatESLint` tests with missing config files ([#17164](eslint/eslint#17164)) (Milos Djermanovic) - [`5b68d51`](eslint/eslint@5b68d51) chore: Fix `fixedsize` attribute in code path analysis DOT debug output ([#17202](eslint/eslint#17202)) (Milos Djermanovic) - [`37432f2`](eslint/eslint@37432f2) chore: update descriptions in key-spacing tests ([#17195](eslint/eslint#17195)) (Milos Djermanovic) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1923 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

test: Add FlatESLint tests with missing config files

ca8dc2b

mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing labels May 8, 2023

mdjermanovic requested a review from a team as a code owner May 8, 2023 09:43

nzakas reviewed May 8, 2023

View reviewed changes

assert ENOENT

1b2058d

BYK reviewed May 11, 2023

View reviewed changes

aladdin-add approved these changes May 12, 2023

View reviewed changes

github-actions bot added the Stale label May 22, 2023

Rec0iL99 removed the Stale label May 22, 2023

nzakas approved these changes May 29, 2023

View reviewed changes

nzakas merged commit f67d298 into main May 29, 2023
22 checks passed

nzakas deleted the test-noconfigfile branch May 29, 2023 18:48

eslint-github-bot bot locked and limited conversation to collaborators Nov 26, 2023

eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Add `FlatESLint` tests with missing config files #17164

test: Add `FlatESLint` tests with missing config files #17164

mdjermanovic commented May 8, 2023

netlify bot commented May 8, 2023 •

edited

nzakas left a comment

nzakas May 8, 2023

mdjermanovic May 10, 2023

BYK May 10, 2023

nzakas May 10, 2023

mdjermanovic May 11, 2023

nzakas May 8, 2023

BYK May 10, 2023

mdjermanovic May 11, 2023

BYK left a comment

aladdin-add left a comment

github-actions bot commented May 22, 2023

Rec0iL99 commented May 22, 2023

nzakas left a comment

	await assert.rejects(() => eslint.lintText("var foo = 'bar';"));
	await assert.rejects(() => eslint.lintText("var foo = 'bar';"), /Could not find config file/u);

	await assert.rejects(() => eslint.lintFiles("undef*.js"));
	await assert.rejects(() => eslint.lintFiles("undef*.js"), /Could not find config file/u);

test: Add FlatESLint tests with missing config files #17164

test: Add FlatESLint tests with missing config files #17164

Conversation

mdjermanovic commented May 8, 2023

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

netlify bot commented May 8, 2023 • edited

✅ Deploy Preview for docs-eslint ready!

nzakas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BYK left a comment

Choose a reason for hiding this comment

aladdin-add left a comment

Choose a reason for hiding this comment

github-actions bot commented May 22, 2023

Rec0iL99 commented May 22, 2023

nzakas left a comment

Choose a reason for hiding this comment

test: Add `FlatESLint` tests with missing config files #17164

test: Add `FlatESLint` tests with missing config files #17164

netlify bot commented May 8, 2023 •

edited