feat: expose shouldUseFlatConfig
#17169
Merged
+117
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
1 task
nzakas
requested changes
May 8, 2023
cprussin
changed the title
shouldUseFlatConfig (#17129)shouldUseFlatConfig (#17129)
cprussin
force-pushed
the
expose-shouldUseFlatConfig
branch
from
c7f2be2 to
3f28705
Compare
nzakas
approved these changes
May 8, 2023
There was a problem hiding this comment.
LGTM. Just one suggestion to clean up the comments.
Would like @mdjermanovic to review before merging.
mdjermanovic
added
core
1 task
mdjermanovic
changed the title
shouldUseFlatConfig (#17129)shouldUseFlatConfig
nzakas
approved these changes
May 9, 2023
mdjermanovic
reviewed
May 9, 2023
mdjermanovic
reviewed
May 9, 2023
cprussin
force-pushed
the
expose-shouldUseFlatConfig
branch
from
a7b5302 to
33ad6bb
Compare
|
thanks for the review @mdjermanovic , I've addressed all your comments -- let me know if there's anything else I can clean up! |
mdjermanovic
approved these changes
May 10, 2023
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
shouldUseFlatConfigfromlib/cli.jstolib/eslint/flat-eslint.jsand exposed it via exportsfindFlatConfigFilefrom exports inlib/eslint/flat-eslint.jssince it was only used to buildshouldUseFlatConfiginlib/cli.jsshouldUseFlatConfigvialib/unsupported-apis.jsshouldUseFlatConfigIs there anything you'd like reviewers to focus on?
Nothing in particular beyond the typical code review