Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't use deprecated context methods in ast-utils tests #17194

Merged
merged 1 commit into from May 18, 2023

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Follow up to #17059.

Updates ast-utils tests to use SourceCode#getDeclaredVariables() instead of now-deprecated context.getDeclaredVariables(). Also updates two tests that were using context.getTokenBefore().

What changes did you make? (Give an overview)

Updated tests.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing labels May 18, 2023
@mdjermanovic mdjermanovic requested a review from a team as a code owner May 18, 2023 08:15
@netlify
Copy link

netlify bot commented May 18, 2023

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 92c3155
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6465de9c2836e900088ee457

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@snitin315 snitin315 merged commit ddc5291 into main May 18, 2023
22 checks passed
@snitin315 snitin315 deleted the tests-astutils-getdeclaredvariables branch May 18, 2023 08:36
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Nov 15, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants