Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update descriptions in key-spacing tests #17195

Merged
merged 1 commit into from May 22, 2023
Merged

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Two tests for the key-spacing rule have an incorrect number of code points in the description.

What changes did you make? (Give an overview)

Updated the descriptions.

Is there anything you'd like reviewers to focus on?

[..."🌷"].length = number of code points, "🌷".length = number of code units,

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing labels May 18, 2023
@mdjermanovic mdjermanovic requested a review from a team as a code owner May 18, 2023 09:00
@netlify
Copy link

netlify bot commented May 18, 2023

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 320f4f0
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6465e94cfe2d67000881b417

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@snitin315 snitin315 merged commit 37432f2 into main May 22, 2023
21 of 22 checks passed
@snitin315 snitin315 deleted the tests-grapheme-counts branch May 22, 2023 02:34
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Jun 8, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.41.0` -> `8.42.0`](https://renovatebot.com/diffs/npm/eslint/8.41.0/8.42.0) |

---

### Release Notes

<details>
<summary>eslint/eslint</summary>

### [`v8.42.0`](https://github.com/eslint/eslint/releases/tag/v8.42.0)

[Compare Source](eslint/eslint@v8.41.0...v8.42.0)

#### Features

-   [`b8448ff`](eslint/eslint@b8448ff) feat: correct no-useless-return behaviour in try statements ([#&#8203;16996](eslint/eslint#16996)) (Nitin Kumar)

#### Bug Fixes

-   [`a589636`](eslint/eslint@a589636) fix: Config with `ignores` and without `files` should not always apply ([#&#8203;17181](eslint/eslint#17181)) (Milos Djermanovic)
-   [`c4fad17`](eslint/eslint@c4fad17) fix: Correct ignore message for "node_modules" subfolders ([#&#8203;17217](eslint/eslint#17217)) (Francesco Trotta)

#### Documentation

-   [`01d7142`](eslint/eslint@01d7142) docs: Update README (GitHub Actions Bot)
-   [`e5182b7`](eslint/eslint@e5182b7) docs: Update README (GitHub Actions Bot)

#### Chores

-   [`6ca5b7c`](eslint/eslint@6ca5b7c) chore: upgrade [@&#8203;eslint/js](https://github.com/eslint/js)[@&#8203;8](https://github.com/8).42.0 ([#&#8203;17236](eslint/eslint#17236)) (Milos Djermanovic)
-   [`67fc5e7`](eslint/eslint@67fc5e7) chore: package.json update for [@&#8203;eslint/js](https://github.com/eslint/js) release (ESLint Jenkins)
-   [`0892412`](eslint/eslint@0892412) refactor: remove `Identifier` listener in no-irregular-whitespace ([#&#8203;17235](eslint/eslint#17235)) (Milos Djermanovic)
-   [`f67d298`](eslint/eslint@f67d298) test: Add `FlatESLint` tests with missing config files ([#&#8203;17164](eslint/eslint#17164)) (Milos Djermanovic)
-   [`5b68d51`](eslint/eslint@5b68d51) chore: Fix `fixedsize` attribute in code path analysis DOT debug output ([#&#8203;17202](eslint/eslint#17202)) (Milos Djermanovic)
-   [`37432f2`](eslint/eslint@37432f2) chore: update descriptions in key-spacing tests ([#&#8203;17195](eslint/eslint#17195)) (Milos Djermanovic)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTMuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMy4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1923
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Nov 19, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants