Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RegExp v flag #17223

Closed
19 tasks done
sosukesuzuki opened this issue May 25, 2023 · 5 comments
Closed
19 tasks done

Support RegExp v flag #17223

sosukesuzuki opened this issue May 25, 2023 · 5 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features new syntax This issue is related to new syntax that has reached stage 4

Comments

@sosukesuzuki
Copy link
Contributor

sosukesuzuki commented May 25, 2023

Syntax name

RegExp v flag with set notation + properties of strings

Syntax proposal URL

https://github.com/tc39/proposal-regexp-v-flag

Example code

/[\p{Decimal_Number}--[0-9]]/v.test(str);

Implementation Checklist

Participation

  • I am willing to submit a pull request for this change.

Additional comments

prev issue: #17199

@sosukesuzuki sosukesuzuki added core Relates to ESLint's core APIs and features new syntax This issue is related to new syntax that has reached stage 4 labels May 25, 2023
@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label May 25, 2023
@mdjermanovic
Copy link
Member

Thanks! Correct, there's no need to update estree, eslint-visitor-keys and eslint-scope. I just added regexpp to the list. cc @ota-meshi

@nzakas
Copy link
Member

nzakas commented Jun 19, 2023

The change to Espree has been completed, so I checked that off the list.

@mdjermanovic
Copy link
Member

I'm working on no-empty-character-class.

@ota-meshi
Copy link
Member

The no-useless-escape rule seems to have false positives.

/[\-]/v; // -> Fix to `/[-]/v`, but it SyntaxError

I will try to fix it.

mdjermanovic added a commit that referenced this issue Jul 26, 2023
Reports nested character classes

Refs #17223
nzakas pushed a commit that referenced this issue Jul 27, 2023
Reports nested character classes

Refs #17223
@nzakas
Copy link
Member

nzakas commented Jul 28, 2023

It looks like all of the checklist items are complete, so closing.

@nzakas nzakas closed this as completed Jul 28, 2023
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jan 25, 2024
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features new syntax This issue is related to new syntax that has reached stage 4
Projects
Archived in project
Development

No branches or pull requests

4 participants