Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typos and missing info #17257

Merged
merged 1 commit into from Jun 8, 2023
Merged

docs: fix typos and missing info #17257

merged 1 commit into from Jun 8, 2023

Conversation

edlucas
Copy link
Contributor

@edlucas edlucas commented Jun 8, 2023

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix (template)
  • New rule (template)
  • Changes an existing rule (template)
  • Add autofix to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

What changes did you make? (Give an overview)

Fixed a typo and added const & let to the list of declarations.

Is there anything you'd like reviewers to focus on?

@edlucas edlucas requested a review from a team as a code owner June 8, 2023 16:15
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jun 8, 2023
@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 8, 2023
mdjermanovic
mdjermanovic approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 35e11d3 into eslint:main Jun 8, 2023
17 checks passed
@mdjermanovic mdjermanovic mentioned this pull request Jun 8, 2023
Closed
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 6, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edlucas @mdjermanovic