Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: resubmit pr17061 doc changes #17292

Merged
merged 1 commit into from Jun 16, 2023
Merged

Conversation

aladdin-add
Copy link
Member

credits: https://github.com/voxpelli

Refs:

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@aladdin-add aladdin-add requested a review from a team as a code owner June 15, 2023 08:35
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jun 15, 2023
@amareshsm amareshsm added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 16, 2023
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we have to ask @voxpelli as the original author of c83531c to give us permission to merge these changes.

@voxpelli
Copy link
Contributor

Yes, you have full permission, thanks for taking the time! It has been on my todo 🙏🙏🙏

@mdjermanovic
Copy link
Member

Thanks! I'm going to merge this now, just in time for the release.

@mdjermanovic mdjermanovic merged commit 8b855ea into eslint:main Jun 16, 2023
16 of 17 checks passed
@aladdin-add aladdin-add deleted the pr17061 branch June 16, 2023 21:18
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 14, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants