Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Request: Update prefer-destructuring rule documentation #17327

Closed
1 task
marcospgp opened this issue Jun 30, 2023 · 2 comments · Fixed by #17330
Closed
1 task

Change Request: Update prefer-destructuring rule documentation #17327

marcospgp opened this issue Jun 30, 2023 · 2 comments · Fixed by #17330
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules

Comments

@marcospgp
Copy link

ESLint version

Latest

What problem do you want to solve?

Documentation was not updated after #11584 was closed

Information is important as confusion causes disabling rule and missing out on benefits

What do you think is the correct solution?

Include info in documentation about how destructuring with assignment to object such as [this.myVar] = myArray is possible

Participation

  • I am willing to submit a pull request for this change.

Additional comments

No response
@marcospgp marcospgp added core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint labels Jun 30, 2023
@mdjermanovic mdjermanovic added rule Relates to ESLint's core rules documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion and removed enhancement This change enhances an existing feature of ESLint core Relates to ESLint's core APIs and features labels Jun 30, 2023
@mdjermanovic
Copy link
Member

Thanks for the issue, a PR is welcome!

mdjermanovic added a commit that referenced this issue Jul 1, 2023
@mdjermanovic
docs: add more prefer-destructuring examples with array destructuring
9225df3 
Fixes #17327
@mdjermanovic mdjermanovic mentioned this issue Jul 1, 2023
Merged
1 task
@mdjermanovic
Copy link
Member

PR #17330

fasttime pushed a commit that referenced this issue Jul 4, 2023
@mdjermanovic
docs: add more prefer-destructuring examples with array destructuring (…
138c096 
…#17330)

Fixes #17327
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jan 1, 2024
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
Triage
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add more prefer-destructuring examples with array destructuring eslint/eslint
2 participants
@marcospgp @mdjermanovic