New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add PRs to triage project #17421
Conversation
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few suggestions above and Lint is also failing. Other than that, LGTM
Co-authored-by: Amaresh S M <amareshsm13@gmail.com>
Co-authored-by: Nitin Kumar <snitin315@gmail.com>
Ah, it looks like the linting error is actually the link checker. Maybe we should run that as a separate CI job to avoid confusion? |
I think it's fine, we anyway need to install deps and build the website to run the link checker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Infrastructure
What changes did you make? (Give an overview)
Adds PRs to the triage project so we can manage issues and PRs in one place.
I also updated the triaging documentation to explicitly mention pull requests.
Related PRs:
Is there anything you'd like reviewers to focus on?
Does the documentation make sense.