Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add PRs to triage project #17421

Merged
merged 4 commits into from Jul 28, 2023
Merged

chore: Add PRs to triage project #17421

merged 4 commits into from Jul 28, 2023

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jul 26, 2023

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Infrastructure

What changes did you make? (Give an overview)

Adds PRs to the triage project so we can manage issues and PRs in one place.

I also updated the triaging documentation to explicitly mention pull requests.

Related PRs:

Is there anything you'd like reviewers to focus on?

Does the documentation make sense.

@nzakas nzakas requested a review from a team as a code owner July 26, 2023 15:38
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Jul 26, 2023
@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 2988655
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/64c2a92bf7fe9a0008a23b16
😎 Deploy Preview https://deploy-preview-17421--docs-eslint.netlify.app/contribute/work-on-issue
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amareshsm amareshsm added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jul 26, 2023
snitin315
snitin315 previously approved these changes Jul 27, 2023
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few suggestions above and Lint is also failing. Other than that, LGTM

@snitin315 snitin315 dismissed their stale review July 27, 2023 04:02

Dismissing to prevent accidental merge

nzakas and others added 2 commits July 27, 2023 13:02
Co-authored-by: Amaresh  S M  <amareshsm13@gmail.com>
Co-authored-by: Nitin Kumar <snitin315@gmail.com>
@nzakas
Copy link
Member Author

nzakas commented Jul 27, 2023

Ah, it looks like the linting error is actually the link checker. Maybe we should run that as a separate CI job to avoid confusion?

@snitin315
Copy link
Contributor

Ah, it looks like the linting error is actually the link checker. Maybe we should run that as a separate CI job to avoid confusion?

I think it's fine, we anyway need to install deps and build the website to run the link checker.

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@snitin315 snitin315 merged commit 0aa0bc3 into main Jul 28, 2023
22 checks passed
@snitin315 snitin315 deleted the pr-triage branch July 28, 2023 01:54
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jan 25, 2024
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

3 participants