test: ensure that CLI tests run with FlatESLint #17884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
nzakas
approved these changes
Dec 20, 2023
fasttime
force-pushed
the
fix-flat-cli-tests
branch
from
1edbd97
to
b9f9caa
Compare
fasttime
commented
Dec 21, 2023
| @@ -54,10 +54,12 @@ describe("cli", () => { | |||
| */ | |||
| async function verifyESLintOpts(cmd, opts, configType) { | |||
|
|
|||
| const ActiveESLint = configType === "flat" ? FlatESLint : ESLint; | |||
There was a problem hiding this comment.
Currently, configType is always undefined when this function (verifyESLintOpts) is called, so ActiveESLint will be always the legacy ESLint.
There was a problem hiding this comment.
Looks like this helper function is used only in two eslintrc-only tests.
Thanks! I rebased my branch to solve some merge conflicts. I think this should be good to go now. |
bmish
added a commit
to bmish/eslint
that referenced
this pull request
Dec 27, 2023
* main: (25 commits) test: ensure that CLI tests run with FlatESLint (eslint#17884) fix!: Behavior of CLI when no arguments are passed (eslint#17644) docs: Update README Revert "feat!: Remove CodePath#currentSegments" (eslint#17890) feat!: Update shouldUseFlatConfig and CLI so flat config is default (eslint#17748) feat!: Remove CodePath#currentSegments (eslint#17756) chore: update dependency markdownlint-cli to ^0.38.0 (eslint#17865) feat!: deprecate no-new-symbol, recommend no-new-native-nonconstructor (eslint#17710) feat!: check for parsing errors in suggestion fixes (eslint#16639) feat!: assert suggestion messages are unique in rule testers (eslint#17532) feat!: `no-invalid-regexp` make allowConstructorFlags case-sensitive (eslint#17533) fix!: no-sequences rule schema correction (eslint#17878) feat!: Update `eslint:recommended` configuration (eslint#17716) feat!: drop support for string configurations in flat config array (eslint#17717) feat!: Remove `SourceCode#getComments()` (eslint#17715) feat!: Remove deprecated context methods (eslint#17698) feat!: Swap FlatESLint-ESLint, FlatRuleTester-RuleTester in API (eslint#17823) feat!: remove formatters except html, json(-with-metadata), and stylish (eslint#17531) feat!: Require Node.js `^18.18.0 || ^20.9.0 || >=21.1.0` (eslint#17725) fix: allow circular references in config (eslint#17752) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:
Fix unit tests.
What changes did you make? (Give an overview)
The test suite for
cli.executeintests/lib/cli.jsis defined twice, once for eslintrc and once for flat config:eslint/tests/lib/cli.js
Line 110 in 0dd9704
This PR updates the test logic so that when the tests run in flat config mode,
FlatESLintis used instead ofESLintconsistently, and theuseFlatConfigparameter is passed tocli.execute.Is there anything you'd like reviewers to focus on?