fix!: upgrade eslint-scope@8.0.0 #17942
Merged
+31
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-github-bot
bot
added
breaking
✅ Deploy Preview for docs-eslint canceled.
|
mdjermanovic
added
core
|
This is ready for review. |
aladdin-add
approved these changes
Jan 4, 2024
This was referenced May 29, 2024
This was referenced Jun 4, 2024
This was referenced Jun 19, 2024
This was referenced Jun 20, 2024
This was referenced Jun 26, 2024
This was referenced Jun 28, 2024
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Upgrades eslint-scope to include eslint/eslint-scope#116 and eslint/eslint-scope#118.
What changes did you make? (Give an overview)
Updated package.json and added a few tests that show different behavior of some rules with eslint-scope v8 (the tests would fail with eslint-scope v7).
Is there anything you'd like reviewers to focus on?
Marked as draft because it currently uses eslint-scope from a branch.