Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Explain limitations of RuleTester fix testing #18175

Merged
merged 3 commits into from Mar 7, 2024
Merged

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Mar 6, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Added documentation explaining how to use RuleTester to test fixes and also added a note explaining the limitations of fix testing.

fixes #18007

Is there anything you'd like reviewers to focus on?

@nzakas nzakas requested a review from a team as a code owner March 6, 2024 19:54
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Mar 6, 2024
Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 95f0d92
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65ea1c0d11b4480008ce217f
😎 Deploy Preview https://deploy-preview-18175--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aladdin-add aladdin-add added the accepted There is consensus among the team that this change meets the criteria for inclusion label Mar 7, 2024
nzakas and others added 2 commits March 7, 2024 12:56
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 337cdf9 into main Mar 7, 2024
19 checks passed
@mdjermanovic mdjermanovic deleted the issue18007 branch March 7, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Change Request: Rule Tester: improve testing of multi-pass fixes
3 participants