feat: add name to eslint configs
#18289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
aladdin-add
force-pushed
the
feat/add-name-to-configs
branch
from
2fe883f
to
f7b41e7
Compare
|
Looks like there are merge conflicts in |
aladdin-add
force-pushed
the
feat/add-name-to-configs
branch
from
f7b41e7
to
43b12ef
Compare
aladdin-add
changed the title
name to exported configsname to eslint configs
aladdin-add
force-pushed
the
feat/add-name-to-configs
branch
2 times, most recently
from
15af7ad
to
7e93954
Compare
aladdin-add
force-pushed
the
feat/add-name-to-configs
branch
from
0261706
to
8cca1dd
Compare
nzakas
previously approved these changes
Apr 15, 2024
mdjermanovic
added
the
accepted
|
There's a merge conflict in |
aladdin-add
force-pushed
the
feat/add-name-to-configs
branch
from
8cca1dd
to
22a5528
Compare
aladdin-add
force-pushed
the
feat/add-name-to-configs
branch
from
22a5528
to
08f55ab
Compare
aladdin-add
commented
Apr 17, 2024
| @@ -1771,7 +1771,7 @@ describe("cli", () => { | |||
| getFixturePath("globals-node.js") | |||
| ]; | |||
|
|
|||
| await cli.execute(`--no-eslintrc --config ./packages/js/src/configs/eslint-recommended.js --no-ignore ${files.join(" ")}`, null, false); | |||
| await cli.execute(`--no-eslintrc --config ./tests/fixtures/config-file/js/.eslintrc.js --no-ignore ${files.join(" ")}`, null, false); | |||
There was a problem hiding this comment.
name is not allowed in eslintrc mode. however, js.configs.recommended was used here, so I updated the test to avoid failing.
|
Part of the changes in this PR have been reverted in #18368 because they were causing some unit tests to fail. The tests started to fail only after upgrading the @eslint/js dependency in eslint's package.json. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ x] Other, please explain:
What changes did you make? (Give an overview)
added name to config, per https://eslint.org/docs/head/use/configure/configuration-files#configuration-naming-conventions
Is there anything you'd like reviewers to focus on?
suggestions for the naming?