fix: don't crash when fs.readFile returns promise from another realm
#18416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cli
mdjermanovic
added
the
accepted
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1 task
fasttime
reviewed
May 5, 2024
tests/lib/eslint/eslint.js
Outdated
| @@ -1057,6 +1057,61 @@ describe("ESLint", () => { | |||
| await assert.rejects(async () => await eslint.lintFiles(["lib/cli.js"]), /Expected object with parse\(\) or parseForESLint\(\) method/u); | |||
| }); | |||
|
|
|||
| // https://github.com/eslint/eslint/issues/18407 | |||
| it("should work in case when `fs.readFile()` returns an object that is not an instance of Promise from this realm", async () => { | |||
There was a problem hiding this comment.
Maybe fs.promises.readFile() or fsp.readFile()?
There was a problem hiding this comment.
Updated to fsp.readFile() in 0b8b96b.
nzakas
approved these changes
May 6, 2024
aladdin-add
approved these changes
May 7, 2024
This was referenced Jun 3, 2024
This was referenced Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Fixes #18407
What changes did you make? (Give an overview)
Updated
@humanwhocodes/retrydependency to the latest v0.2.4 that includes the fix for #18407 and added a test that fails with v0.2.3.Also updates
lib/eslint/eslint.jsto userequire("fs/promises")instead ofrequire("fs").promises.Is there anything you'd like reviewers to focus on?