padded-blocks fails on comment

[keradus]

Hi. When I have a code:

if (a) {
    // we really need to test it
    if (b) {
        c();
    }

    d();
}

The rule warns me: Block must not be padded by blank lines padded-blocks.
It should not since comment is not blank line.

When I remove a comment then rule passes.

[lo1tuma]

Can you share your eslint configuration? Do you use the default parser?

[keradus]

Default parser it is.

{
    "rules": {
        "padded-blocks": [2, "never"]
    }
}

[lo1tuma]

You disabled the rule in your configuration. So it should never warn.

However, I've tried your example in the online demo and can’t reproduce the problem:

/* eslint padded-blocks: [2, "never"] */

if (a) {
    // we really need to test it
    if (b) {
        c();
    }

    d();
}

Which version of ESLint do you use?

[keradus]

"padded-blocks": 0, // S3: docelowo [2, "never"],
yeah, error occurs only with commented setting. I need to disable it due to that problem. Sorry for that.

ESLint version: 0.22.1

[keradus]

same on 0.23.0

[keradus]

Please try this

/* eslint padded-blocks: [2, "never"] */

var xxx = function () {
    // foo
    if (
        // bar
        a ||
        // baz
        b
    ) {
        return;
    }
};

[lo1tuma]

Now I can reproduce it.

Here is more minimal example:

/* eslint padded-blocks: [2, "never"] */

{
    // comment
    if (// comment
        a) {}
}

This is a problem with the comment attachment algorithm of espree. Both comments are getting attached to the Identifier node inside the if condition. The current implementation of the rule would expect that the first comment gets attached to the IfStatement node.

[nzakas]

Can you file an espree bug?

[moll]

Just stumbled upon this too. Same issue with trailing comments.

function foo() {
  console.log("Hi")

  // Long text.
  // Long text.
  // Long text.
}

[lo1tuma]

@moll This is a different issue caused by the missing semicolon after console.log("Hi"), see #2336.

[lo1tuma]

For reference eslint/espree#155

[keradus]

Great to have that fixed! Waiting for next stable release ;)