-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent validation of keywords as identifiers in method declaration in ES8 #9153
Comments
Thanks for the report. This looks like a bug in the acorn parser -- I've reported it at acornjs/acorn#584. |
This has been fixed upstream in acorn, so it should be fixed in ESLint next time acorn is released. |
Maybe we should leave this open and do an espree release and Upgrade commit against this issue when Acorn is released? Just to avoid any oddities for our users when it is available due to open dependency ranges? |
Sure, works for me. |
This reverts commit 787b78b.
* Revert "4.7.0" This reverts commit 439e8e6. * Revert "Build: changelog update for 4.7.0" This reverts commit 2ec62f9. * Revert "Upgrade: Espree v3.5.1 (fixes #9153) (#9314)" This reverts commit 787b78b. * Revert "Update: run rules after `node.parent` is already set (fixes #9122) (#9283)" This reverts commit 1488b51. * Revert "Docs: fix wrong config in max-len example. (#9309)" This reverts commit 4431d68. * Revert "Chore: Revert "avoid handling Rules instances in config-validator" (#9295)" This reverts commit 9d1df92. * Revert "Docs: Fix code snippet to refer to the correct option (#9313)" This reverts commit 7d24dde. * Revert "�Chore: rewrite parseListConfig for a small perf gain. (#9300)" This reverts commit 12388d4.
Tell us about your environment
4.5.0
Please show your full configuration:
Reproducible in online REPL using a default configuration with ES8 enabled
https://eslint.org/demo/
What did you do? Please include the actual source code causing the issue.
What did you expect to happen?
All "delete" method declarations should be either valid or invalid
What actually happened? Please include the actual, raw output from ESLint.
Eslint fails to parse method declaration for
asyncInstance
.The text was updated successfully, but these errors were encountered: