Chore: remove Linter#reset (refs #9161) #9268
Merged
+5
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-an-aardvark
added
blocked
|
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas, @mysticatea and @gyandeeps to be potential reviewers. |
not-an-aardvark
force-pushed
the
remove-linter-reset
branch
from
b4ed508 to
040058b
Compare
|
LGTM |
not-an-aardvark
removed
the
blocked
not-an-aardvark
force-pushed
the
remove-linter-reset
branch
from
040058b to
9ecd264
Compare
|
LGTM |
gyandeeps
approved these changes
Sep 11, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
This updates
Linterto remove the undocumentedresetmethod.It also removes the fourth argument from
Linter#verify, because that argument now has no effect at all. (It was previously used to control what happened to the internal state of theLinterinstance, but now theLinterinstance has no internal state except for thesourceCodeproperty, which was always reset regardless). In fact, the fourth argument has never had any effect for users that only used documented APIs. Integrations that use the fourth argument will continue to work the same way that they did before (the fourth argument will just be ignored now).This builds on top of #9267. The first commit is from that PR. For this PR, only look at the second commit for now (I'll rebase after #9267 is merged).Refs: #9161
Is there anything you'd like reviewers to focus on?
Nothing in particular