Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating migration guide for single-line disable #9385

Merged
merged 1 commit into from
Nov 26, 2017

Conversation

justinhelmer
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

The multiline comment string doesn't seem to work.

Main docs page is right; JSCS migration guide appears to be wrong.

Is there anything you'd like reviewers to focus on?

@jsf-clabot
Copy link

jsf-clabot commented Oct 4, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Justin Helmer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@eslintbot
Copy link

Thanks for the pull request, @justinhelmer! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@justinhelmer
Copy link
Contributor Author

as requested

@platinumazure
Copy link
Member

Thanks! Can you please sign our Contributor License Agreement?

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@not-an-aardvark not-an-aardvark added the documentation Relates to ESLint's documentation label Oct 5, 2017
@ilyavolodin
Copy link
Member

@justinhelmer just a friendly ping. Could you sign our CLA? Unfortunately we can't merge anything without a signed CLA.

@kaicataldo
Copy link
Member

@justinhelmer Friendly ping. We'd love to land this, but we unfortunately can't until the CLA is signed.

@justinhelmer
Copy link
Contributor Author

I signed this way back.

@justinhelmer
Copy link
Contributor Author

The status in the comment is incorrect, it was signed a long time back

@kaicataldo
Copy link
Member

@kborchers Hi! Any idea what might be going on here re the CLA bot?

@kborchers
Copy link

The commit was made by an account that GitHub doesn't recognize so this was either done with a different account that was deleted or something was done to the commit that edited the author information so it can't be tied to @justinhelmer.

@aladdin-add
Copy link
Member

aladdin-add commented Oct 25, 2017

oh, I have encountered it before(my first contribution to ESLint 😄 ).
maybe it's because your git configed email has not been added in github. could you please check it? @justinhelmer

image

@platinumazure
Copy link
Member

@justinhelmer Have you had a chance to look into the CLA issue, using the information provided here and here?

@justinhelmer
Copy link
Contributor Author

@platinumazure apologize for not getting back sooner, I have been out of town.

I added my work email, hoping it will solve the problem

@justinhelmer
Copy link
Contributor Author

The CLA assistant continues to show it signed, but it doesn't allow me to change emails. Let me know if there is any other action I need to take.

@platinumazure
Copy link
Member

Closing/reopening the pull request seems to have fixed the CLA status. Now the only issue is the commit message (should just start with "Docs:"). Maybe we could take care of that on merge, but if you do get a chance to amend the commit summary, that would be super awesome. Thinks!

@justinhelmer
Copy link
Contributor Author

justinhelmer commented Nov 26, 2017

edit: I wrote Fix: instead... updating now.

@justinhelmer
Copy link
Contributor Author

Done!

@platinumazure
Copy link
Member

platinumazure commented Nov 26, 2017

Thank you! This looks good to me, I'll go ahead and merge shortly (assuming the Travis and AppVeyor checks pass). Thanks so much for your patience on this!

@platinumazure platinumazure merged commit 92171cc into eslint:master Nov 26, 2017
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators May 26, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants