-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating migration guide for single-line disable #9385
Conversation
Justin Helmer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
Thanks for the pull request, @justinhelmer! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
Thanks! Can you please sign our Contributor License Agreement? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for contributing!
@justinhelmer just a friendly ping. Could you sign our CLA? Unfortunately we can't merge anything without a signed CLA. |
@justinhelmer Friendly ping. We'd love to land this, but we unfortunately can't until the CLA is signed. |
I signed this way back. |
The status in the comment is incorrect, it was signed a long time back |
@kborchers Hi! Any idea what might be going on here re the CLA bot? |
The commit was made by an account that GitHub doesn't recognize so this was either done with a different account that was deleted or something was done to the commit that edited the author information so it can't be tied to @justinhelmer. |
oh, I have encountered it before(my first contribution to ESLint 😄 ). |
@justinhelmer Have you had a chance to look into the CLA issue, using the information provided here and here? |
@platinumazure apologize for not getting back sooner, I have been out of town. I added my work email, hoping it will solve the problem |
The CLA assistant continues to show it signed, but it doesn't allow me to change emails. Let me know if there is any other action I need to take. |
Closing/reopening the pull request seems to have fixed the CLA status. Now the only issue is the commit message (should just start with "Docs:"). Maybe we could take care of that on merge, but if you do get a chance to amend the commit summary, that would be super awesome. Thinks! |
edit: I wrote |
Done! |
Thank you! This looks good to me, I'll go ahead and merge shortly (assuming the Travis and AppVeyor checks pass). Thanks so much for your patience on this! |
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
The multiline comment string doesn't seem to work.
Main docs page is right; JSCS migration guide appears to be wrong.
Is there anything you'd like reviewers to focus on?