Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: upgrade globals to 11.0.1 (fixes #9614) #9632

Merged
merged 2 commits into from
Nov 26, 2017
Merged

Update: upgrade globals to 11.0.1 (fixes #9614) #9632

merged 2 commits into from
Nov 26, 2017

Conversation

mysticatea
Copy link
Member

@mysticatea mysticatea commented Nov 17, 2017 •
edited

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix (template)

Fixes #9614.
Closes #9555.

What changes did you make? (Give an overview)

This PR upgrades the dependency to globals package to 11.x from 9.x (diff).

Estimated effects:

  • no-undef rule reports System variables (System not detected as an undefined variable #9614).
  • no-shadow and no-redeclare with {builtinGlobals: true} option no longer report System variables.
  • no-extend-native rule reports about Atomics and SharedBufferArray.

  • node environment no longer has the deprecated globals: root, GLOBAL, and arguments.
  • browser environment is updated massively. The new globals are based on the global variables of current Chrome Canary. EDIT: there are not deleted variables
  • jasmine gets spyOnProperty variable.
  • jest gets wait variable and no longer has check and gen.
  • greasemonkey gets GM variable.

Is there anything you'd like reviewers to focus on?

I think we can release the changes in the next minor version because those are bug fixes.
But the diff is large a bit. What do you think?

@mysticatea mysticatea added bug ESLint is working incorrectly core Relates to ESLint's core APIs and features evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion do not merge This pull request should not be merged yet labels Nov 17, 2017
@sindresorhus
Copy link
Contributor

@mysticatea I just published v11.0.1.

@mysticatea
Copy link
Member Author

@sindresorhus Thank you!

@mysticatea mysticatea changed the title [WIP] Update: upgrade globals to 11.0.0 (fixes #9614) Update: upgrade globals to 11.0.0 (fixes #9614) Nov 17, 2017
@mysticatea mysticatea removed the do not merge This pull request should not be merged yet label Nov 17, 2017
@mysticatea mysticatea changed the title Update: upgrade globals to 11.0.0 (fixes #9614) Update: upgrade globals to 11.0.1 (fixes #9614) Nov 17, 2017
@aladdin-add
Copy link
Member

I think it would be a breaking change. see #9555

@kaicataldo
Copy link
Member

I'd like to see this land, but I am a little concerned about the breaking changes. This feels like it could affect more users since it's not isolated to a single rule and is an actual change in core.

Also, should we close #9555 in favor of this?

@platinumazure
Copy link
Member

For the environments where globals are being removed: Could we patch those globals in our environment config (as suggested by @not-an-aardvark) and take an action item to remove those patches (and therefore remove the globals for our users) in our next major release?

@mysticatea
Copy link
Member Author

mysticatea commented Nov 21, 2017 •
edited

I patched the deleted globals of browser, node, and jest environments. I confirmed other variables were not deleted (except System).

platinumazure
platinumazure approved these changes Nov 24, 2017
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Nov 26, 2017
@not-an-aardvark not-an-aardvark merged commit 6e04f14 into master Nov 26, 2017
@not-an-aardvark not-an-aardvark deleted the upgrade-globals branch November 26, 2017 02:33
@renovate renovate bot mentioned this pull request Feb 14, 2018
Merged
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators May 26, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

@aladdin-add aladdin-add aladdin-add approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System not detected as an undefined variable
6 participants
@mysticatea @sindresorhus @aladdin-add @kaicataldo @platinumazure @not-an-aardvark