Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: space-in-parens crash #9655

Merged
merged 1 commit into from
Nov 26, 2017
Merged

Fix: space-in-parens crash #9655

merged 1 commit into from
Nov 26, 2017

Conversation

mysticatea
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix (template)

Tell us about your environment

  • ESLint Version: master
  • Node Version: 8.9.1
  • npm Version: 5.5.1

What parser (default, Babel-ESLint, etc.) are you using?

  • default

Please show your full configuration:

  • nothing

What did you do? Please include the actual source code causing the issue.

/* eslint space-in-parens: [error, always, {}] */
1

I couldn't get the URL of our online demo because it crashes. Please copy/paste then see devtools' console.

What did you expect to happen?

No errors.

What actually happened? Please include the actual, raw output from ESLint.

A type error was thrown.

Uncaught TypeError: Error while loading rule 'space-in-parens': Cannot read property 'length' of undefined

What changes did you make? (Give an overview)

This PR fixes space-in-parens rule not crashing.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@mysticatea mysticatea added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules labels Nov 24, 2017
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit e13d439 into master Nov 26, 2017
@not-an-aardvark not-an-aardvark deleted the space-in-parens/crash branch November 26, 2017 02:31
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators May 26, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants