Fix: eol-last allow empty-string to always pass (refs #9534) #9696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that there are already tests asserting this behavior, but they aren't actually run in the rules. See #9534
platinumazure
added
accepted
ilyavolodin
approved these changes
Dec 8, 2017
btmills
approved these changes
Dec 11, 2017
This was referenced Mar 8, 2018
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that there are already tests asserting this behavior, but they aren't actually run in the rules. See #9534.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Add code to explicitly allow empty string source to pass linting in eol-last even when newline is required in config.
Is there anything you'd like reviewers to focus on?
Note that there is already test coverage (although the tests are not actually run in the rule due to #9534). I applied the same patch to Linter that not-an-aardvark had done in order to test the changes locally.