Chore: no-invalid-meta crash if no export assignment (refs #9534) #9698
Conversation
|
Hmm. Since this doesn't impact end-users (though it could impact developers/contributors?), should this be a Chore? |
|
yes this should be a chore |
platinumazure
force-pushed
the
no-invalid-meta-fix-error
branch
from
7de7af6
to
1d032d9
Compare
platinumazure
changed the title
|
@gyandeeps Fixed, this is now a Chore. Thanks! |
|
|
||
| /* | ||
| * Should be invalid, but will currently show as valid due to #9534. | ||
| * FIXME: Uncomment when #9534 is fixed in major release. |
There was a problem hiding this comment.
Can we add a note about this to the 5.0.0 milestone so we don't forget?
There was a problem hiding this comment.
👍, how would I go about doing that?
There was a problem hiding this comment.
Looks like we should make an issue to list these kinds of changes or just make an issue for the change itself.
There was a problem hiding this comment.
If you look at a column on the milestone page, and then click on the "+" near the top-right of the column, it allows you to add a note with arbitrary text.
There was a problem hiding this comment.
Thanks, I've added a note. I can convert into an issue if needed.
platinumazure
added
accepted
eslint-deprecated
bot
added
the
archived due to age
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
See #9534.
What changes did you make? (Give an overview)
Added new lint error report for files that don't assign to
module.exports, avoiding a crash that otherwise occurs later in the rule.Is there anything you'd like reviewers to focus on?
One test had to be commented out due to #9534. Otherwise, not really.