-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
comment at end of line confuses indent's handling of ternary operator #9729
Closed
Jessidhia opened this issue
Dec 18, 2017
· 3 comments
· Fixed by Urigo/tortilla#62, mono-js/mono-notifications#5, mono-js/mono-push#5 or terrajs/lib-starter#5 · May be fixed by ali8889/emerald-wallet#4
Closed
comment at end of line confuses indent's handling of ternary operator #9729
Jessidhia opened this issue
Dec 18, 2017
· 3 comments
· Fixed by Urigo/tortilla#62, mono-js/mono-notifications#5, mono-js/mono-push#5 or terrajs/lib-starter#5 · May be fixed by ali8889/emerald-wallet#4
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
bug
ESLint is working incorrectly
indent
Relates to the `indent` rule
rule
Relates to ESLint's core rules
Comments
eslint-deprecated
bot
added
the
triage
An ESLint team member will look at this issue soon
label
Dec 18, 2017
platinumazure
added
bug
ESLint is working incorrectly
evaluating
The team will evaluate this issue to decide whether it meets the criteria for inclusion
indent
Relates to the `indent` rule
rule
Relates to ESLint's core rules
and removed
triage
An ESLint team member will look at this issue soon
labels
Dec 20, 2017
This sounds like a bug to me, but I'll defer to @not-an-aardvark. |
not-an-aardvark
added
accepted
There is consensus among the team that this change meets the criteria for inclusion
and removed
evaluating
The team will evaluate this issue to decide whether it meets the criteria for inclusion
labels
Dec 20, 2017
Working on this. (Edit: Might take me a couple of days-- if someone else wants to work on this, just let me know here and I'll stop. Thanks!) |
I think I see what's wrong -- I'll work on it for a bit. |
not-an-aardvark
added a commit
that referenced
this issue
Jan 7, 2018
This was referenced Mar 8, 2018
eslint-deprecated
bot
added
the
archived due to age
This issue has been archived; please open a new issue for any further discussion
label
Jul 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
bug
ESLint is working incorrectly
indent
Relates to the `indent` rule
rule
Relates to ESLint's core rules
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using? babel-eslint
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.
What did you expect to happen?
1
to be indented at the same level as2
What actually happened? Please include the actual, raw output from ESLint.
The source code above is formatted according to
eslint --fix
.indent
wants to indent the1
at the same level as thereturn
statement. Removing the// comment
after the?
clearsindent
's confusion and it does put1
at the same indent level as2
.Putting the
?
on the next line also works around the problem.The text was updated successfully, but these errors were encountered: