-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: clean up key-spacing docs (fixes #9900) #9963
Conversation
Hi @abiduzz420, thanks for the PR! Just a quick summary of what the failed status checks mean:
Once you have 2 or more commits in a pull request, we check the PR title in the commit-message check. So my suggestion would be to push a 2nd commit to fix the Markdown lint issues, and then change the PR title to fix the commit-message check. Thanks for your understanding! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I'd like to wait for one more review before merging.
Thanks for contributing! |
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Categorized key-spacing options based on their values.
Is there anything you'd like reviewers to focus on?
No