-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Propose fix typo for function #9965
Conversation
Hello @jeis2497052 |
Sorry, can I repair this PR or start again? |
Not sure if or how to repair? |
PR title could be directly edited from the UI. For making changes to the commit message, you could take the help of this: https://help.github.com/articles/changing-a-commit-message/ EDIT: If you need additional help, here it is
|
is the UI edit OK now with Docs: added? |
Hi @jeis2497052, thanks for contributing! Our commit message check will look at either the first commit's commit message, or the PR title, depending on the number of commits in the PR. If the PR has 1 commit, we look at the commit message; if 2 or more, we look at the PR title. This is because GitHub's squash and merge interface uses the exact same logic to decide what commit message to suggest when we are about to merge. Right now, your PR title matches our guidelines, but the commit message does not, and there is only one commit. I think we could handle this using one of the following approaches:
The last option is probably the "best" option, but also the most annoying on your end. Let me know how you would like to proceed. |
Did I properly amend ? |
@jeis2497052 Yes! Everything looks great now and our commit-message status check is happy 😄 Thanks so much for taking the time to do this, it really helps us out and it makes our changelog beautiful. TravisCI and AppVeyor need to rerun due to the forced push, but hopefully those will pass soon enough. |
Thanks for the pull request. |
@@ -20,7 +20,7 @@ Examples of **incorrect** code for this rule: | |||
typeof foo === "strnig" | |||
typeof foo == "undefimed" | |||
typeof bar != "nunber" | |||
typeof bar !== "fucntion" | |||
typeof bar !== "function" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@platinumazure @jeis2497052 I think this is wrong. These are deliberate typos, aren't they?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, would you like to create a PR to fix this example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#10459 :)
This was accidentally removed in eslint#9965.
This was accidentally removed in eslint#9965.
This was accidentally removed in #9965.
What is the purpose of this pull request? (put an "X" next to item)
[ X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?