From c842ffa0d7ae1b9997dce50e9fad98a9af8ddbd1 Mon Sep 17 00:00:00 2001 From: "weiran.zsd" Date: Sat, 10 Nov 2018 22:42:14 +0800 Subject: [PATCH 1/4] Chore: refactor linter#parseBooleanConfig to improve readability --- lib/linter.js | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/lib/linter.js b/lib/linter.js index b47e6eb1fcf..4426b7f67c6 100644 --- a/lib/linter.js +++ b/lib/linter.js @@ -76,19 +76,13 @@ function parseBooleanConfig(string, comment) { if (!name) { return; } - const pos = name.indexOf(":"); - if (pos === -1) { - items[name] = { - value: false, - comment - }; - } else { - items[name.slice(0, pos)] = { - value: name.slice(pos + 1) === "true", - comment - }; - } + const [key, value] = name.split(":"); + + items[key] = { + value: value === "true", + comment + }; }); return items; } From ae823fe02b4b3c639514ec90153ee8fbb23d594b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E8=96=9B=E5=AE=9A=E8=B0=94=E7=9A=84=E7=8C=AB?= Date: Sun, 11 Nov 2018 12:05:47 +0800 Subject: [PATCH 2/4] Update linter.js --- lib/linter.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/linter.js b/lib/linter.js index 4426b7f67c6..3e62b8ecbbc 100644 --- a/lib/linter.js +++ b/lib/linter.js @@ -77,7 +77,8 @@ function parseBooleanConfig(string, comment) { return; } - const [key, value] = name.split(":"); + // value defaults to false (if not provided), e.g: "foo" => ["foo", false] + const [key, value = false ] = name.split(":"); items[key] = { value: value === "true", From c10b350fe1342be51c66397a456e3bd3f4ac1079 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E8=96=9B=E5=AE=9A=E8=B0=94=E7=9A=84=E7=8C=AB?= Date: Sun, 11 Nov 2018 12:07:44 +0800 Subject: [PATCH 3/4] Update linter.js --- lib/linter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/linter.js b/lib/linter.js index 3e62b8ecbbc..fd1ddd7d0a7 100644 --- a/lib/linter.js +++ b/lib/linter.js @@ -78,7 +78,7 @@ function parseBooleanConfig(string, comment) { } // value defaults to false (if not provided), e.g: "foo" => ["foo", false] - const [key, value = false ] = name.split(":"); + const [key, value = false] = name.split(":"); items[key] = { value: value === "true", From e2dbb67bd403808d7dabd8c2299174750da08961 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E8=96=9B=E5=AE=9A=E8=B0=94=E7=9A=84=E7=8C=AB?= Date: Sun, 11 Nov 2018 12:21:09 +0800 Subject: [PATCH 4/4] Update linter.js --- lib/linter.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/linter.js b/lib/linter.js index fd1ddd7d0a7..edcf741069c 100644 --- a/lib/linter.js +++ b/lib/linter.js @@ -77,8 +77,8 @@ function parseBooleanConfig(string, comment) { return; } - // value defaults to false (if not provided), e.g: "foo" => ["foo", false] - const [key, value = false] = name.split(":"); + // value defaults to "false" (if not provided), e.g: "foo" => ["foo", "false"] + const [key, value = "false"] = name.split(":"); items[key] = { value: value === "true",