From 34abbabf7375e5daec06d24eacb9c20acabc880d Mon Sep 17 00:00:00 2001 From: Ivan V Date: Fri, 30 Aug 2019 21:03:44 +0200 Subject: [PATCH 1/2] Properly format styleguide links When using the initializer and coming to style guide step, visual studio code terminal doesn't properly format style guide links so when user clicks on one of the links it takes them to e.q `https://github.com/airbnb/javascript)` (note the `)` at the end) Putting spaces between links and opening and closing braces fixes this. --- lib/init/config-initializer.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/init/config-initializer.js b/lib/init/config-initializer.js index 17aa96505a3..7b6573fb54b 100644 --- a/lib/init/config-initializer.js +++ b/lib/init/config-initializer.js @@ -494,9 +494,9 @@ function promptUser() { name: "styleguide", message: "Which style guide do you want to follow?", choices: [ - { name: "Airbnb (https://github.com/airbnb/javascript)", value: "airbnb" }, - { name: "Standard (https://github.com/standard/standard)", value: "standard" }, - { name: "Google (https://github.com/google/eslint-config-google)", value: "google" } + { name: "Airbnb ( https://github.com/airbnb/javascript )", value: "airbnb" }, + { name: "Standard ( https://github.com/standard/standard )", value: "standard" }, + { name: "Google ( https://github.com/google/eslint-config-google )", value: "google" } ], when(answers) { answers.packageJsonExists = npmUtils.checkPackageJson(); From 63a66ca3481f8b8d81f3a1f70d8dfa83a0d3cd48 Mon Sep 17 00:00:00 2001 From: Ivan V <390700+ivandotv@users.noreply.github.com> Date: Mon, 30 Sep 2019 13:57:54 +0200 Subject: [PATCH 2/2] Remove braces around links Remove braces around links and add a colon at the beginning. --- lib/init/config-initializer.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/init/config-initializer.js b/lib/init/config-initializer.js index 7b6573fb54b..334c783f54e 100644 --- a/lib/init/config-initializer.js +++ b/lib/init/config-initializer.js @@ -494,9 +494,9 @@ function promptUser() { name: "styleguide", message: "Which style guide do you want to follow?", choices: [ - { name: "Airbnb ( https://github.com/airbnb/javascript )", value: "airbnb" }, - { name: "Standard ( https://github.com/standard/standard )", value: "standard" }, - { name: "Google ( https://github.com/google/eslint-config-google )", value: "google" } + { name: "Airbnb: https://github.com/airbnb/javascript", value: "airbnb" }, + { name: "Standard: https://github.com/standard/standard", value: "standard" }, + { name: "Google: https://github.com/google/eslint-config-google", value: "google" } ], when(answers) { answers.packageJsonExists = npmUtils.checkPackageJson();