From 256b4a952357321def3d5d4cf3f7f14080ffbd12 Mon Sep 17 00:00:00 2001 From: Milos Djermanovic Date: Sun, 8 Sep 2019 00:07:17 +0200 Subject: [PATCH 1/2] Docs: fix no-sequences `with` examples --- docs/rules/no-sequences.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/docs/rules/no-sequences.md b/docs/rules/no-sequences.md index f1f4afea0ac..f83f5a59687 100644 --- a/docs/rules/no-sequences.md +++ b/docs/rules/no-sequences.md @@ -37,8 +37,6 @@ if (doSomething(), !!test); switch (val = foo(), val) {} while (val = foo(), val < 42); - -with (doSomething(), val) {} ``` Examples of **correct** code for this rule: @@ -59,8 +57,6 @@ if ((doSomething(), !!test)); switch ((val = foo(), val)) {} while ((val = foo(), val < 42)); - -// with ((doSomething(), val)) {} ``` ## When Not To Use It From 2707b39aa198a858514cea2ef0a7409ad6ec0fee Mon Sep 17 00:00:00 2001 From: Milos Djermanovic Date: Sun, 8 Sep 2019 01:53:14 +0200 Subject: [PATCH 2/2] Revert and just uncomment the example --- docs/rules/no-sequences.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/rules/no-sequences.md b/docs/rules/no-sequences.md index f83f5a59687..602a412f16a 100644 --- a/docs/rules/no-sequences.md +++ b/docs/rules/no-sequences.md @@ -37,6 +37,8 @@ if (doSomething(), !!test); switch (val = foo(), val) {} while (val = foo(), val < 42); + +with (doSomething(), val) {} ``` Examples of **correct** code for this rule: @@ -57,6 +59,8 @@ if ((doSomething(), !!test)); switch ((val = foo(), val)) {} while ((val = foo(), val < 42)); + +with ((doSomething(), val)) {} ``` ## When Not To Use It