From df2282c8d136ddc38596392a9fed3c3b031457bc Mon Sep 17 00:00:00 2001 From: Brandon Mills Date: Sun, 15 Aug 2021 00:59:21 -0400 Subject: [PATCH 1/2] Build: Force prerelease peer dep for Node 16 in CI Several dev dependencies have a peer dependency on the local ESLint. Prereleases don't satisfy regular version range constraints, so the new peer dependency resolution algorithm in Node 16 rejects `v8.0.0-beta.0` as a valid peer dependency. Until we're done with prereleases, we can use the `--force` flag to force npm to accept that the prerelease satisfies the peer dependency. --- .github/workflows/ci.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 170bf15b018..6a16b43e26b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -42,6 +42,10 @@ jobs: node-version: ${{ matrix.node }} - name: Install Packages run: npm install + if: ${{ !startswith(matrix.node, '16') }} + - name: Install Packages + run: npm install --force + if: ${{ startswith(matrix.node, '16') }} - name: Test run: node Makefile mocha - name: Fuzz Test From 972238c4860520b4584199884d618a9f0e487f9b Mon Sep 17 00:00:00 2001 From: Brandon Mills Date: Sun, 15 Aug 2021 15:31:03 -0400 Subject: [PATCH 2/2] Add todo comment to remove Node 16 --force branching --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6a16b43e26b..bf15885f021 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -42,6 +42,7 @@ jobs: node-version: ${{ matrix.node }} - name: Install Packages run: npm install + # TODO(btmills): Remove Node 16 --force branching after releasing v8.0.0 final. if: ${{ !startswith(matrix.node, '16') }} - name: Install Packages run: npm install --force