From 85d6209e1a7fb0237b9d8beca74545bc2c6e37bb Mon Sep 17 00:00:00 2001 From: Sebastian Simon <37915283+SebastianSimon@users.noreply.github.com> Date: Thu, 12 Jan 2023 13:47:21 +0100 Subject: [PATCH 1/2] docs: Add multi-comparison example to no-constant-condition --- docs/src/rules/no-constant-condition.md | 28 +++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/docs/src/rules/no-constant-condition.md b/docs/src/rules/no-constant-condition.md index 828a036ca48..c28e84ebed6 100644 --- a/docs/src/rules/no-constant-condition.md +++ b/docs/src/rules/no-constant-condition.md @@ -106,6 +106,34 @@ var result = x !== 0 ? a : b; ::: +This rule also applies to this more subtle example. This is an **incorrect** way to compare a variable against two values: + +::: incorrect + +```js +/*eslint no-constant-condition: "error"*/ + +if(input === "hello" || "bye"){ + output(input); +} +``` + +::: + +This is a **correct** way to compare a variable against two values: + +::: correct + +```js +/*eslint no-constant-condition: "error"*/ + +if(input === "hello" || input === "bye"){ + output(input); +} +``` + +::: + ## Options ### checkLoops From dcefbeaebe0d0672af0c511bc6333d5929ce2748 Mon Sep 17 00:00:00 2001 From: Sebastian Simon <37915283+SebastianSimon@users.noreply.github.com> Date: Tue, 24 Jan 2023 02:07:44 +0100 Subject: [PATCH 2/2] Merge new example into existing code blocks --- docs/src/rules/no-constant-condition.md | 28 ++++--------------------- 1 file changed, 4 insertions(+), 24 deletions(-) diff --git a/docs/src/rules/no-constant-condition.md b/docs/src/rules/no-constant-condition.md index c28e84ebed6..2ac613f7abf 100644 --- a/docs/src/rules/no-constant-condition.md +++ b/docs/src/rules/no-constant-condition.md @@ -74,6 +74,10 @@ do { } while (x = -1); var result = 0 ? a : b; + +if(input === "hello" || "bye"){ + output(input); +} ``` ::: @@ -102,30 +106,6 @@ do { } while (x); var result = x !== 0 ? a : b; -``` - -::: - -This rule also applies to this more subtle example. This is an **incorrect** way to compare a variable against two values: - -::: incorrect - -```js -/*eslint no-constant-condition: "error"*/ - -if(input === "hello" || "bye"){ - output(input); -} -``` - -::: - -This is a **correct** way to compare a variable against two values: - -::: correct - -```js -/*eslint no-constant-condition: "error"*/ if(input === "hello" || input === "bye"){ output(input);