From 7506733a3db10f7ebc51c0b4bb570cf9ff8b333e Mon Sep 17 00:00:00 2001 From: Percy Ma Date: Sun, 24 Sep 2023 17:28:23 +0800 Subject: [PATCH 1/4] docs: use generated og image --- docs/src/_includes/layouts/base.html | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/docs/src/_includes/layouts/base.html b/docs/src/_includes/layouts/base.html index 49bdf8522c8..361b60d4ada 100644 --- a/docs/src/_includes/layouts/base.html +++ b/docs/src/_includes/layouts/base.html @@ -13,11 +13,19 @@ {% set page_title = site[hook].title %} {% endif %} + {% set rule_meta = rules_meta[title] %} {% set page_title = site.shared.title_format | replace("PAGE_TITLE", page_title) %} - {% set cover_image = ["https://", site.hostname, "/icon-512.png" ] | join %} - {% set cover_image_alt = site.shared.eslint_logo_alt %} {% set page_desc = site.shared.description %} {% set relative_page_url = page.url | url | prettyURL %} + {% set cover_image = [ + "http://", "localhost:56606", "/og", + "?title=", title, "&summary=", page_desc, + "&is_rule=", rule_meta !== undefined, + "&recommended=", rule_meta.docs.recommended, + "&fixable=", rule_meta.fixable, + "&suggestions=", rule_meta.hasSuggestions + ] | join %} + {% set cover_image_alt = site.shared.eslint_logo_alt %} {% set page_url = ["https://", site.hostname, relative_page_url ] | join %} From 190cc3a4063a302108d256204a443b391085ca6e Mon Sep 17 00:00:00 2001 From: Percy Ma Date: Mon, 25 Sep 2023 14:49:00 +0800 Subject: [PATCH 2/4] fix: revert code for testing --- docs/src/_includes/layouts/base.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/_includes/layouts/base.html b/docs/src/_includes/layouts/base.html index 361b60d4ada..e8affa35745 100644 --- a/docs/src/_includes/layouts/base.html +++ b/docs/src/_includes/layouts/base.html @@ -18,7 +18,7 @@ {% set page_desc = site.shared.description %} {% set relative_page_url = page.url | url | prettyURL %} {% set cover_image = [ - "http://", "localhost:56606", "/og", + "http://", site.hostname, "/og", "?title=", title, "&summary=", page_desc, "&is_rule=", rule_meta !== undefined, "&recommended=", rule_meta.docs.recommended, From b79d815b2c014fbad0c2a0d3cbf16e40a7d988be Mon Sep 17 00:00:00 2001 From: Percy Ma Date: Tue, 26 Sep 2023 23:00:48 +0800 Subject: [PATCH 3/4] Update docs/src/_includes/layouts/base.html Co-authored-by: Milos Djermanovic --- docs/src/_includes/layouts/base.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/_includes/layouts/base.html b/docs/src/_includes/layouts/base.html index e8affa35745..5420cd71609 100644 --- a/docs/src/_includes/layouts/base.html +++ b/docs/src/_includes/layouts/base.html @@ -18,7 +18,7 @@ {% set page_desc = site.shared.description %} {% set relative_page_url = page.url | url | prettyURL %} {% set cover_image = [ - "http://", site.hostname, "/og", + "https://", site.hostname, "/og", "?title=", title, "&summary=", page_desc, "&is_rule=", rule_meta !== undefined, "&recommended=", rule_meta.docs.recommended, From 278f6f9feda9826774efd2033ca078b71892acf5 Mon Sep 17 00:00:00 2001 From: Percy Ma Date: Sun, 1 Oct 2023 23:28:42 +0800 Subject: [PATCH 4/4] chore: urlencode title and summary in og --- docs/src/_includes/layouts/base.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/_includes/layouts/base.html b/docs/src/_includes/layouts/base.html index 5420cd71609..86ea680c3cb 100644 --- a/docs/src/_includes/layouts/base.html +++ b/docs/src/_includes/layouts/base.html @@ -19,7 +19,7 @@ {% set relative_page_url = page.url | url | prettyURL %} {% set cover_image = [ "https://", site.hostname, "/og", - "?title=", title, "&summary=", page_desc, + "?title=", title | urlencode, "&summary=", page_desc | urlencode, "&is_rule=", rule_meta !== undefined, "&recommended=", rule_meta.docs.recommended, "&fixable=", rule_meta.fixable,