Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint Browser Test fails #50

Closed
mdjermanovic opened this issue Aug 5, 2021 · 2 comments · Fixed by #51
Closed

ESLint Browser Test fails #50

mdjermanovic opened this issue Aug 5, 2021 · 2 comments · Fixed by #51
Labels
Projects

Comments

@mdjermanovic
Copy link
Member

The current main branch of @eslint/eslintrc breaks Browser Test in eslint/eslint. Consequently, the ESLint demo won't work.

eslint/eslint#14865 (comment)

How to reproduce locally:

  1. Check out the branch from Upgrade: @eslint/eslintrc@1.0.0 eslint#14865
  2. Run node Makefile.js karma

The fix might include some updates in eslint/eslintrc repo and/or updates in webpack.config.js in eslint/eslint repo. I tried several approaches and nothing worked (fixing some errors always produces new errors).

I'd suggest reverting #39.

@eslint-github-bot eslint-github-bot bot added this to Needs Triage in Triage Aug 5, 2021
@nzakas nzakas moved this from Needs Triage to Evaluating in Triage Aug 6, 2021
@nzakas
Copy link
Member

nzakas commented Aug 6, 2021

Running node Makefile.js webpack is a faster option.

@nzakas
Copy link
Member

nzakas commented Aug 6, 2021

This is happening because ./lib/linter.js in ESLint is including all of @eslint/eslintrc, including the Node.js-specific functionality. We can work around this by creating a separate entrypoint in @eslint/eslintrc that just exposes what we need in linter for browser-specific functionality.

@mdjermanovic mdjermanovic linked a pull request Aug 6, 2021 that will close this issue
@nzakas nzakas closed this as completed in #51 Aug 7, 2021
Triage automation moved this from Evaluating to Complete Aug 7, 2021
nzakas added a commit that referenced this issue Aug 7, 2021
* Update: Add /universal entrypoint (fixes #50)

* Fix lint error

* Embed JSON data for ajv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Triage
Complete
Development

Successfully merging a pull request may close this issue.

2 participants