Chore: fix tests for Node 6+ #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few issues with the tests causing them to fail with Node 6 and above: * When parsing regular expression literals with the `y` and `u` flags, espree expected the `value` property of the resulting `Literal` node to `null`. However, since Node 6+ supports these flags, the `value` property was actually a regular expression with the corresponding flags. This commit updates the tests to conditionally expect a regex or `null` depending on whether the flags are supported in the current environment. * For invalid regular expressions with the `u` flag, Acorn outputs a different error message depending on whether the current environment supports the `u` flag. This commit updates the tests to conditionally expect a particular error message depending on whether the current environment supports the `u` flag.
ilyavolodin
approved these changes
Feb 3, 2017
gyandeeps
approved these changes
Feb 3, 2017
btmills
approved these changes
Feb 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few issues with the tests causing them to fail with Node 6 and above:
yanduflags, espree expected thevalueproperty of the resultingLiteralnode tonull. However, since Node 6+ supports these flags, thevalueproperty was actually a regular expression with the corresponding flags. This commit updates the tests to conditionally expect a regex ornulldepending on whether the flags are supported in the current environment.uflag, Acorn outputs a different error message depending on whether the current environment supports theuflag. This commit updates the tests to conditionally expect a particular error message depending on whether the current environment supports theuflag.