Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: upgrade acorn to support two ES2019 syntax #380

Merged
merged 3 commits into from Jun 4, 2018

Conversation

mysticatea
Copy link
Member

@mysticatea mysticatea commented May 31, 2018

Refs: eslint/eslint#10392

This PR upgrades acorn to 5.6.0 to support new ES2019 syntax:

  • optional catch binding
  • JSON superset (\u2028 and \u2029 in string literals)

Also, this PR makes espree allowing ecmaVersion: 10.

@mysticatea mysticatea changed the title Update: upgrade acorn to support two ES2019 syntax (refs eslint/eslint#10392) Update: upgrade acorn to support two ES2019 syntax May 31, 2018
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM outside of one potential typo.

README.md Outdated
@@ -143,11 +143,24 @@ There are two ECMAScript 2017 syntax changes: `async` functions, and trailing co

### What ECMAScript 2018 features do you support?

Because ECMAScript 2018 is still under development, we are implementing features as they are finalized. Currently, Espree supports:
There are seven ECMAScript 2017 syntax changes:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This says 2017 but the header above says 2018. Typo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops, yes, it's typo. Thank you.

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but might be good to have more eyes on this. Thanks!

@platinumazure platinumazure merged commit cd9da7e into master Jun 4, 2018
@platinumazure
Copy link
Member

platinumazure commented Jun 4, 2018

Preserving the branch for now since there is an open PR on ESLint which references this branch. (That said, I think it would be good to cut a new espree release, even if it's just an alpha or rc, and consume that in ESLint.)

(cc @mysticatea)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants