New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: upgrade acorn to support two ES2019 syntax #380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM outside of one potential typo.
README.md
Outdated
@@ -143,11 +143,24 @@ There are two ECMAScript 2017 syntax changes: `async` functions, and trailing co | |||
|
|||
### What ECMAScript 2018 features do you support? | |||
|
|||
Because ECMAScript 2018 is still under development, we are implementing features as they are finalized. Currently, Espree supports: | |||
There are seven ECMAScript 2017 syntax changes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This says 2017 but the header above says 2018. Typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ops, yes, it's typo. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but might be good to have more eyes on this. Thanks!
Preserving the branch for now since there is an open PR on ESLint which references this branch. (That said, I think it would be good to cut a new espree release, even if it's just an alpha or rc, and consume that in ESLint.) (cc @mysticatea) |
Refs: eslint/eslint#10392
This PR upgrades acorn to 5.6.0 to support new ES2019 syntax:
catch
binding\u2028
and\u2029
in string literals)Also, this PR makes espree allowing
ecmaVersion: 10
.